Center and Split string with maxchar

Question

I have many hours thinking how i can solve, this is my funtion:

private String TextAlignCenter(String Line)
{
    String CenterLine = String.Empty;

    if (Line.Length > 36)
    {
        for (int i = 0; i < Line.Length; i += 36)
        {
            if ((i + 36) < Line.Length)
                TextAlignCenter(Line.Substring(i, 36));
            else
                TextAlignCenter(Line.Substring(i));
        }
    }
    else
    {
        Int32 CountLineSpaces = (int)(36 - Line.Length) / 2;
        for (int i = 0; i < CountLineSpaces; i++)
        {
            CenterLine += (Char)32;
        }
        CenterLine += Line;
    }
    Console.WriteLine(CenterLine);
    return CenterLine;
}

This function split a string in parts of 36 characters then add the resultant characters with spaces for make a centered text: For example:

string x = "27 Calle, Col. Ciudad Nueva, San Pedro Sula, Cortes";
TextAlignCenter(x);

Result:

Line1: 27 Calle, Col. Ciudad Nueva, San Ped
Line2:          ro Sula, Cortes
Line3:[EmptyLine]

Line1 and Line2 are correct but i dont need the Line3, how i can prevent to print this unnecessary line?

UPDATE:

The lines are added into a ArrayList()

ArrayList Lines = new ArrayList();
string x = "27 Calle, Col. Ciudad Nueva, San Pedro Sula, Cortes";
Lines.Add(TextAlignCenter(x));
Console.WriteLine(Lines.Count);

Dmitry Bychenko · Accepted Answer · 2015-09-04T09:17:40.333

All you need is a loop for full chunks and a special condition for the last one:

    public static IEnumerable<String> SplitByLength(String value, 
      int size, // you may want to set default for size, i.e. "size = 36"
      Char padding = ' ') {

      if (String.IsNullOrEmpty(value)) 
        yield break; // or throw an exception or return new String(padding, size);

      if (size <= 0)
        throw new ArgumentOutOfRangeException("size", "size must be a positive value");

      // full chunks with "size" length
      for (int i = 0; i < value.Length / size; ++i)
        yield return value.Substring(i * size, size);

      // the last chunk (if it exists) should be padded
      if (value.Length % size > 0) {
        String chunk = value.Substring(value.Length / size * size);

        yield return new String(padding, (size - chunk.Length) / 2) + 
          chunk + 
          new String(padding, (size - chunk.Length + 1) / 2);
      }
    }
...

String source = "27 Calle, Col. Ciudad Nueva, San Pedro Sula, Cortes";

// I've set padding to '*' in order to show it
// 27 Calle, 
// Col. Ciuda
// d Nueva, S
// an Pedro S
// ula, Corte
// ****s*****
Console.Write(String.Join(Environment.NewLine,
  SplitByLength(source, 10, '*')));

Your sample:

  string x = "27 Calle, Col. Ciudad Nueva, San Pedro Sula, Cortes";
  List<String> lines = SplitByLength(x, 36).ToList();

That is! It is just what I needed, Thanks. – Jonathan Nuñez Sep 04 '15 at 07:58 — Jonathan Nuñez, Sep 04 '15 at 07:58

score 2 · Answer 2 · edited Oct 01 '19 at 10:32

2

You don't need recursive function here. Also some operations are not optimal.

private static String TextAlignCenter(String Line)
{
    int len = 36; // avoid magic numbers
    StringBuilder b = new StringBuilder(); 
    String CenterLine = String.Empty;

    for (int i = 0; i < Line.Length; i += len)
    {
        if ((i + len) < Line.Length)
            b.AppendLine(Line.Substring(i, len));  // add new line at the end                     
        else
        {
            CenterLine = Line.Substring(i);
            int CountLineSpaces = (len - CenterLine.Length) / 2;    
            // new string(' ', CountLineSpaces) replicates ' '  CountLineSpaces times
            CenterLine = new string(' ', CountLineSpaces) + CenterLine;                     
            b.Append(CenterLine);  // string tail, no new line
        }
    }

    Console.WriteLine(b.ToString());
    return b.ToString();
}

fiddle demo

edited Oct 01 '19 at 10:32

Simson

3,373
2
24
38

answered Sep 04 '15 at 07:09

ASh

34,632
9
60
82

Hy your solution is good but I need to return one string per line. – Jonathan Nuñez Sep 04 '15 at 07:24
@JonathanEdgardo, `TextAlignCenter` returns 1 string; in your code the last one (the tail of `Line`); *one string per line* in my understanding is an array of string. Or try `Console.WriteLine`in place of `b.AppendLine` and `Console.Write`in place of `b.Append` – ASh Sep 04 '15 at 07:41
please take a look to my update, i need add each line into a array that is because i need 1 string per line. – Jonathan Nuñez Sep 04 '15 at 07:47

score 1 · Answer 3 · answered Sep 04 '15 at 07:08

1

I would go with Console.Write instead:

private void TextAlignCenter(String Line)
{
    String CenterLine = String.Empty;

    if (Line.Length > 36)
    {
        for (int i = 0; i < Line.Length; i += 36)
        {
            if ((i + 36) < Line.Length)
                TextAlignCenter(Line.Substring(i, 36));
            else
                TextAlignCenter(Line.Substring(i));
        }
    }
    else
    {
        Int32 CountLineSpaces = (36 - Line.Length) / 2;
        for (int i = 0; i < CountLineSpaces; i++)
        {
            CenterLine += (Char)32;
        }
        CenterLine += Line + Environment.NewLine;
    }
    Console.Write(CenterLine);
}

answered Sep 04 '15 at 07:08

Thomas Ayoub

29,063
15
95
142

Hello Thomas, i like your solution too but i need this function return one string per line. – Jonathan Nuñez Sep 04 '15 at 07:29
@JonathanEdgardo but do you really use the string then? If so, change `void` to `string` and add `return CenterLine;` at the end – Thomas Ayoub Sep 04 '15 at 07:31
please take a look to my update, i need to use recursive because each line need to be saved into an Array. in this case only 2. – Jonathan Nuñez Sep 04 '15 at 07:50

Center and Split string with maxchar

3 Answers3