How to refine this code, in terms of performance and readability?

Question

My Desired output :

if the difference is less than a minute the result should be "Updated just now" and if the difference is than greater than a minute and less than an hour then the result should be "Updated X mintues ago"

Code:

string result = "";
if (difference.Days == 0)
{
    if (difference.Hours == 0)
    {
        if (difference.Minutes == 0)
        {
            result = "Updated just now";
        }
        else
        {
            result = "Updated " + difference.Minutes.ToString() + " minutes ago";
        }                   
    }
    else
    {
        result = "Updated " + difference.Hours.ToString() + " hours ago";
    }
}
else
{
    result = "Updated " + difference.Days.ToString() + " days ago";
}

good. where is your problem? if there is no problem in this code then ask it on Code review. — M.kazem Akhgary, Sep 04 '15 at 10:22
You should put it in code review http://codereview.stackexchange.com/ — Yahya, Sep 04 '15 at 10:23
possible duplicate of [How do I calculate relative time?](http://stackoverflow.com/questions/11/how-do-i-calculate-relative-time) — Yahya, Sep 04 '15 at 10:25

score 2 · Answer 1 · answered Sep 04 '15 at 10:22

string result = "Updated ";

if (difference.Days != 0)
    result += difference.Days.ToString() + " days ago";
else if (difference.Hours != 0)
    result += difference.Hours.ToString() + " hours ago";
else if (difference.Minutes != 0)
    result += difference.Minutes.ToString() + " minutes ago";
else
    result += "just now";

score 2 · Accepted Answer · answered Sep 04 '15 at 10:46

string format = "Updated {0} {1} ago";
string result = "Updated just now";
// this test can be deleted
if(difference.TotalSeconds > 60)
{
  if(difference.Days != 0)
    result = string.Format(format, difference.Days, "days");
  else if (difference.Hours != 0)
    result = string.Format(format, difference.Hours, "Hours");
  else if (difference.Minutes != 0)
    result = string.Format(format, difference.Minutes, "Minutes");
}

so that the result is cleaner, replace "days" by difference.Days > 1 ? "Days" : "Day"

the purpose of the format string, is to avoid memory leak and to allow user change text format easily and for multilang

How to refine this code, in terms of performance and readability?

2 Answers2