reversing a string of characters

Question

While trying to reverse a string of characters using the mentioned program, the string reverses only till half. I don't know where the problem is occuring

void reverse(char *s)
{
    char *t=s;
    while(*t)
        t++;
    t--;
    while(*s)
    {
        char temp=*t;
        *s++=*t;
        *t--=temp;
    }
}

int main()
{
    char s[100];
    gets(s);
    reverse(s);
    cout<<s;
    return 0;
}

[Don't use gets](http://stackoverflow.com/questions/1694036/why-is-the-gets-function-so-dangerous-that-it-should-not-be-used) — crashmstr, Sep 10 '15 at 15:17

score 3 · Answer 1 · answered Sep 10 '15 at 15:16

You store the value of t in temp, and then later assign temp back to t again!

You meant to store the value of s in temp, so that t gets the value that was in s before.

Also, you don't want to keep swapping characters all the way through the string!
If you do, you'll swap the first-character with with the last one, and then later, swap the last one with the first one again!

You want your swap-loop to be:

while(s < t)
{
    char temp=*s;
    *s++=*t;
    *t--=temp;
}

Link to IDEOne

reversing a string of characters

1 Answers1