unexpected $end in foreach loop

Question

I am getting error which cause unexpected $end.Without loop its works but not working with foreach loop.Any help is appreciated.I am getting error of unexpected $end.My code is here.How could i solve this?enter code here

<?php 
              global $mysqli;
              $res_rdid2 = $objfetch->fetch_relation("route_id,did_id","where `did_id`=$id and `timeset_id`='0' and `routing_type`='ER'");
              error_log("----fetch ----$res_rdid2--");
              $ext_type="";
              $encrypt_id = "";
              $t= $res_rdid2[0]['route_id'];
              error_log("====$t==");
              echo $res_rdid2['route_id'];
              $result = $objfetch->fetch_didCallRouting("*","where `route_id`='".$res_routeid2['route_id']."' and `did_id`='".$res_routeid2['did_id']."' ORDER BY priority ASC ");
                    foreach($result as $row)
                    {
                        $encrypt_id = base64_encode($row['id']);
                        if($row['ext_type']=="a"){$ext_type="Actual";}
                        if($row['ext_type']=="v"){$ext_type="Virtual";}
                        if($row['ext_type']=="vm"){$ext_type="Voice Mail";}

                        //fetch DID
                        $result2 = $objfetch->fetch_did("`DID`,`did_name`","where `id`='".$row['did_id']."'");
                        $didname2 = "";
                        if($result2[0]['did_name']!="")
                        {
                            $didname2 = " (".$result2[0]['did_name'].")";
                        }

                        //fetch extension
                        if($row['ext_type']=="a" or $row['ext_type']=="vm")
                        {
                            $result3 = $objfetch->fetch_ext("`ext_number`", "where `id`='".$row['ext_id']."'");
                            $ext = $result3[0]['ext_number'];
                        }
                        else
                        {
                            $result4 = $objfetch->fetch_virtualext("`ext`", "where `id`='".$row['ext_id']."'");
                            $ext = $result4[0]['ext'];
                        }

        ?>              
                      <tr>
                        <td><?php echo $result2[0]['did'].$didname2;?></td>
                        <td><?php echo "To Extension";?></td>
                        <td><?php echo "-";?></td>
                        <td><?php echo $row['priority'];?></td>
                        <td><?php echo $ext_type;?></td>
                        <td><?php echo $ext;?></td>
                    </tr>
                  <?php}?>
         </tbody>
    </table>

GiamPy · Answer 1 · 2015-09-11T10:28:16.513

0

You are missing the PHP closing tag ?> before <tr>.

Try this.

I have also improved the readability of the code.

<?php 

    global $mysqli;

    $res_rdid2 = $objfetch->fetch_relation(
        "route_id, did_id",
        "where `did_id`= {$id} and `timeset_id`='0' and `routing_type`='ER'"
    );

    error_log("----fetch ----{$res_rdid2}--");

    $ext_type   = "";
    $encrypt_id = "";
    $t = $res_rdid2[0]['route_id'];

    error_log("===={$t}==");

    echo $res_rdid2['route_id'];

    $result = $objfetch->fetch_didCallRouting(
        "*",
        "where `route_id` = '{$res_routeid2['route_id']}' and `did_id` = '{$res_routeid2['did_id']}' ORDER BY priority ASC"
    );

    foreach($result as $row)
    {
        $encrypt_id = base64_encode($row['id']);

        if($row['ext_type'] === "a")
            $ext_type = "Actual";

        if($row['ext_type'] === "v")
            $ext_type = "Virtual";

        if($row['ext_type'] === "vm")
            $ext_type = "Voice Mail";

        // Fetch DID.

        $result2  = $objfetch->fetch_did(
            "`DID`, `did_name`",
            "where `id` = '{$row['did_id']}'"
        );

        $didname2 = "";

        if($result2[0]['did_name'] != "")
            $didname2 = " ({$result2[0]['did_name']})";

        // Fetch extension.

        if($row['ext_type'] === "a" or $row['ext_type'] === "vm")
        {
            $result3 = $objfetch->fetch_ext(
                "`ext_number`", 
                "where `id`='{$row['ext_id']}'"
            );

            $ext = $result3[0]['ext_number'];
        }
        else
        {
            $result4 = $objfetch->fetch_virtualext(
                "`ext`",
                "where `id`='{$row['ext_id']}'"
            );

            $ext = $result4[0]['ext'];
        }

        ?>        

        <tr>
            <td><?= $result2[0]['did'].$didname2 ?></td>
            <td>"To Extension"</td>
            <td>-</td>
            <td><?= $row['priority'] ?></td>
            <td><?= $ext_type ?></td>
            <td><?= $ext ?></td>
        </tr>


    <?php

    }

    ?>

    </tbody>
</table>

edited Sep 11 '15 at 10:28

answered Sep 11 '15 at 10:12

GiamPy

3,543
3
30
51

1

No `}` is missing. It is closed after printing the `tr`. And OP needs to print the `tr` inside the loop. – Sougata Bose Sep 11 '15 at 10:15
@b0s3 Fixed. The code was not very readable. – GiamPy Sep 11 '15 at 10:16
Now it is changing the output as `tr`s should be printed inside the loop. – Sougata Bose Sep 11 '15 at 10:18
no success.I have update my code please check – soni8010 Sep 11 '15 at 10:19
You can try now. @b0se question fixed – GiamPy Sep 11 '15 at 10:26
You could improve the readability **further** by using the [alternative control structure syntax](http://php.net/manual/en/control-structures.alternative-syntax.php). – jhmckimm Sep 11 '15 at 10:27
@GiamPy The `foreach()` closing brace. I'll admit, however, that I only saw that and didn't see that the top-half of the code was all just PHP. – jhmckimm Sep 11 '15 at 10:34
error solved.But didn't get any value table. – soni8010 Sep 11 '15 at 10:45
@soni8010 It's likely to be another issue in the code unrelated to this question. – GiamPy Sep 11 '15 at 10:46
i got value before without foreach – soni8010 Sep 11 '15 at 10:48

score 0 · Answer 2 · answered Sep 11 '15 at 10:14

put

?>

after

if($row['ext_type']=="a" or $row['ext_type']=="vm")
{
  $result3 = $objfetch->fetch_ext("`ext_number`", "where `id`='".$row['ext_id']."'");
  $ext = $result3[0]['ext_number'];
}
else
{
  $result4 = $objfetch->fetch_virtualext("`ext`", "where `id`='".$row['ext_id']."'");
  $ext = $result4[0]['ext'];
}

score 0 · Accepted Answer · answered Sep 11 '15 at 10:31

<tr>
                    <td><?php echo $result2[0]['did'].$didname2;?></td>
                    <td><?php echo "To Extension";?></td>
                    <td><?php echo "-";?></td>
                    <td><?php echo $row['priority'];?></td>
                    <td><?php echo $ext_type;?></td>
                    <td><?php echo $ext;?></td>
                </tr>
              <?php  }  ?>  // please give space here.
     </tbody>
</table>

unexpected $end in foreach loop

3 Answers3