SQLite database is not being created and no error coming

Question

SQLite database is not being created while no error coming.

I have checked the android/data folder trying many things. I am using eclipse. Someone kindly help me and thanks in advance.

My Database.java file is this:

public class Database extends SQLiteOpenHelper {

    public static final String DATABASE_NAME="Table.db";
    public static final String TABLE_NAME="table_one";
    public static final String COL_1="ID";
    public static final String COL_2="NAME";
    public static final String COL_3="SURNAME";
    public static final String COL_4="MARKS";

    public Database(Context context) {
        super(context, TABLE_NAME, null, 1);
        // TODO Auto-generated constructor stub
    }

    @Override
    public void onCreate(SQLiteDatabase arg) {
        // TODO Auto-generated method stub
        arg.execSQL("create table "+TABLE_NAME+"(ID INTEGER PRIMARY KEY AUTOINCREMENT, NAME TEXT, SURNAME TEXT, MARKS INTEGER)");
    }

    @Override
    public void onUpgrade(SQLiteDatabase arg, int arg1, int arg2) {
        // TODO Auto-generated method stub
        arg.execSQL("DROP TABLE IF EXISTS "+TABLE_NAME);
        onCreate(arg);
    }

    public boolean insert(String name, String sname, String marks)
    {
        SQLiteDatabase arg=this.getWritableDatabase();
        ContentValues content=new ContentValues();
        content.put(COL_2, name);
        content.put(COL_3, sname);
        content.put(COL_4, marks);
        long result=arg.insert(TABLE_NAME, null, content);
        if(result==-1)
            return false;
        else
        return true;

    }
}

MainActivity.java is:

public class MainActivity extends Activity {

    Database myDb;
    EditText name, sname, marks;
    Button add;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        myDb = new Database(this);
        name = (EditText) findViewById(R.id.ename);
        sname = (EditText) findViewById(R.id.esname);
        marks = (EditText) findViewById(R.id.emarks);
        add = (Button) findViewById(R.id.button1);
        addData();
    }

    public void addData() {
        add.setOnClickListener(new View.OnClickListener() {

            @Override
            public void onClick(View arg0) {
                // TODO Auto-generated method stub
                boolean isInserted = myDb.insert(name.getText().toString(), sname.getText().toString(), marks.getText().toString());
                if (isInserted == true)
                    Toast.makeText(MainActivity.this, "Data is inserted", Toast.LENGTH_LONG).show();
                else
                    Toast.makeText(MainActivity.this, "Data is NOT inserted", Toast.LENGTH_LONG).show();
            }
        });
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

}

leave a space before the opening bracket like `TABLE_NAME+" (` and it should be `_id` not `id` — Blackbelt, Sep 24 '15 at 13:45
change table name to database name super(context, DATABASE_NAME, null, 1) and ref this http://stackoverflow.com/questions/21881992/when-is-sqliteopenhelper-oncreate-onupgrade-run — arun, Sep 24 '15 at 13:48
i changed it from TABLE_NAME to DATABASE_NAME still no effect and Blackbelt can you specify the _id and not id- thing please. — Anmol, Sep 28 '15 at 11:36

score 1 · Answer 1 · answered Sep 24 '15 at 13:53

1

public Database(Context context)
    {
        super(context, DATABASE_NAME , null, 1); // Your Mistake
    }

Create your table like this :

String CREATE_TABLE = "CREATE TABLE " + GROUP_CHAT_MESSAGE_TABLE_NAME + "("
                + ID + " INTEGER PRIMARY KEY," 
                + NAME + " TEXT,"
                + SURNAME + " TEXT ,"                                   
                + MARKS + " INTEGER" + ")";

db.execSQL(CREATE_TABLE);

answered Sep 24 '15 at 13:53

KishuDroid

5,411
4
30
47

still its not working. The main thing is that I get the message "Data is inserted" when I click on add button but when I go to Android->Data there is see no folder for my package. – Anmol Sep 28 '15 at 11:34
You can check your data in emulator only – KishuDroid Sep 28 '15 at 11:38
For time saving purpose I am using a smartphone to launch my app instead of emulator. – Anmol Sep 29 '15 at 16:36
you cannot check your sqlite database in your mobile device , instead of emulator you can use GenyMotion which works faster than emulator. – KishuDroid Sep 30 '15 at 04:50

score 0 · Answer 2 · answered Sep 24 '15 at 17:21

Try taking a look here . You should however use a DAO class ; so you can manage information from the database and to it ,through an intermediate object.

Try creating the table like this :

private static final String DATABASE_CREATE = "create table "
        + DATABASE_NAME + "(" + COL_1 +
        " integer primary key autoincrement, "  +
        COL_2 + " text not null, "  + COL_3 + " text not null, " + COL_4 + " integer);";

SQLite database is not being created and no error coming

2 Answers2