Difference between std:string and std::string

Question

In one function of my code I found a bug. It was written std:string :

const std::string currentDateTime() {
    time_t     now = time(0);
    struct tm  tstruct;
    char       buf[80];
    tstruct = *localtime(&now);
    //strftime(buf, sizeof(buf), "%Y-%m-%d.%X", &tstruct);
    strftime(buf, sizeof(buf), "%Y%m%d%X", &tstruct);

    std:string str = buf;

    str.erase(std::remove(str.begin(), str.end(), ':'), str.end());
    return str;
}

The code compiles without errors. Why does it compile? What does std:string mean then?

`std:` is a label, there must be a using in there someplace. — Shafik Yaghmour, Oct 09 '15 at 12:14
This code only works if you are doing "using namespace std" which is IMO bad anyway. Otherwise this would have been caught as a compile error unless there is a type string somewhere defined. — Devolus, Oct 09 '15 at 12:16
@Devolus You can also do using std::string, to get this same effect. — dascandy, Oct 09 '15 at 12:19
Both clang and gcc provide an unused label warning for this. — Shafik Yaghmour, Oct 09 '15 at 12:20
I recently found and fixed that same bug in some code coworkers wrote. Bug #1, there was a `using namespace std;` in an include file where it really really should not have been. Fix bug #1 and compiling failed on bug #2 `std:string` — JSF, Oct 09 '15 at 12:39

score 20 · Answer 1 · answered Oct 09 '15 at 12:15

It is interpreted as a label that can be used with goto.

int main()
{
    //label to jump to:
    label_name:
    //some code
    <..>
    //some code
    goto label_name;//jump to the line with the lable
}

Obviously that was a typo. Your code compiled because using namespace std; or using std::string was used somewhere above. Otherwise you'd get a "string was not declared in this scope" error.

Nikko · Answer 2 · 2015-10-09T12:28:07.457

6

I think it compiles because the infamous "using namespace std;" directive was used above in the file ( or worse, in another included file ).

So the compiler sees "std:" as a goto label, and uses (std::)string because "using namespace std" was used.

Normally on modern compiler you may have a warning, something like (in gcc):

  warning: label ‘std’ defined but not used

edited Oct 09 '15 at 12:28

answered Oct 09 '15 at 12:17

Nikko

4,182
1
26
44

1

There are a couple of issues with this answer, `using namespace std;` is not the only way for this to come up and although it is true gcc can warn for this the OP tagged the question Visual C++ and the warning are not automatic you need to turn them on. If they were automatic the OP would have discovered the problem and never have asked the question. So the root of the problem is not having warnings turned on. – Shafik Yaghmour Oct 09 '15 at 13:03

score 6 · Answer 3 · edited May 23 '17 at 12:23

std: is being used as a label which can be used as the target of a goto. There must be a using directive someplace in your code either:

using std::string;

or:

using namespace std;

Also see Why is “using namespace std;” considered bad practice?.

This demonstrates the importance of using warnings. I can get Visual Studio, gcc and clang to warn for this using the correct flags. For Visual Studio using /W3 gives the following warning (see it live):

warning C4102: 'std' : unreferenced label

For this code:

#include <string>

using std::string ;

int main()
{
    std:string s1 ;
}

For gcc and clang using -Wall was sufficient, for gcc I receive the following:

warning: label 'std' defined but not used [-Wunused-label]
 std:string s1 ;
 ^

and a similar warning from clang.

Difference between std:string and std::string

3 Answers3