Text printing in an infinite loop

Question

The text is printing in an infinite loop. Any way to avoid these?

if (eLoad) {
    File file = new File("reservation.txt");

    /** reading a file */

    try(FileInputStream fis = new FileInputStream(file)) {
        int content;
        while ((content = fis.read()) != -1) {
            // convert to char and display it  
            System.out.print((char) content);
            /**print out the result contents of the file. */
        }
    }

    catch(IOException e) {
        e.printStackTrace();
    }
}

Ooutput shown

Homeworkdue Sat Oct 10 00:00:00 PDT 2015 23:00 23
Homeworkdue Sat Oct 10 00:00:00 PDT 2015 23:00 23
Homeworkdue Sat Oct 10 00:00:00 PDT 2015 23:00 23

HERE IS THE LINK TO SOLVE THOSE PROBELMS http://stackoverflow.com/questions/731365/reading-and-displaying-data-from-a-txt-file — B-Y, Oct 10 '15 at 06:58

Shiladittya Chakraborty · Answer 1 · 2015-10-10T08:34:33.477

0

if (eLoad) {
    File file = new File("reservation.txt");

    /** reading a file */

    try(FileInputStream fis = new FileInputStream(file)) {
        int content;

        BufferedReader reader = new BufferedReader(new InputStreamReader(fis));
        String line = null;

        while ((line = reader.readLine()) != null) {
         // convert to char and display it  
            System.out.print(line);
            /**print out the result contents of the file. */
        }

        reader.close();
    }

    catch(IOException e) {
        e.printStackTrace();
    }
}

edited Oct 10 '15 at 08:34

answered Oct 10 '15 at 06:05

Shiladittya Chakraborty

4,270
8
45
94

Can you explain why you think it is helpful? Because it isn't. – Tom Oct 10 '15 at 08:13
If file read is end then its return null then stop the execution that its break the loop. – Shiladittya Chakraborty Oct 10 '15 at 08:15
So you still think the `int` variable `content` can be `null`? – Tom Oct 10 '15 at 08:17
Oh sorry I misread that line. Its working for if its string. – Shiladittya Chakraborty Oct 10 '15 at 08:19
It won't, because `fis.read()` doesn't return a `String`. So there is other stuff to fix. – Tom Oct 10 '15 at 08:21
String line = null; while ((line = reader.readLine()) != null) { } In that way it can be work. – Shiladittya Chakraborty Oct 10 '15 at 08:22
Yes, that is better. You may should update your answer. – Tom Oct 10 '15 at 08:23

score 0 · Answer 2 · edited Mar 20 '17 at 10:18

Can you add

System.out.print(content);

after

System.out.print((char) content);

I'm not very knowledgeable yet in programming but it may be because it is reading fis.read() as ASCII values, and it is either 000 or 003.

If so I would put

content = fis.read());
while (content != 3 && content != 0 || content == null) // if either not 3 and not 0 it doesn't run or if it isn't defined
{
    // do stuff
}

for the while condition

Quote: "That means, the API try to read a line of file, get -1 and returns EOF." (Looks like it doesn't return -1)

Looked at: https://superuser.com/questions/789026/eof-ascii-hex-code-in-text-files

score 0 · Answer 3 · answered Oct 10 '15 at 06:10

0

If you wish to read in line by line from a file you could also try

 while ((line = fis.readLine()) != null) {

The rest of the code looks fine.

answered Oct 10 '15 at 06:10

Aven

72
10

score 0 · Answer 4 · edited Oct 10 '15 at 06:38

if (eLoad) {
    File file = new File("reservation.txt");

    /** reading a file */

    try(FileInputStream fis = new FileInputStream(file)) {
        int content;
        while ((content = fis.read()) != 0) //JUST CHANGE THE -1 TO 0, THEN IT WORKS {
            // convert to char and display it  
            System.out.print((char) content);
        /**print out the result contents of the file. */
    }

    catch(IOException e) {
        e.printStackTrace();
    }
}

Text printing in an infinite loop

4 Answers4