NSInvocation trigger memory leak

Question

i test in NSInvocation with ARC, but it trigger memory leaks. In MRC, it work well. i do not know why.

- (NSArray *)a:(NSString *)a b:(NSString *)b c:(NSString *)c
{
    return  @[a, b, c];
}
- (void)testNSInvocation
{
    NSMethodSignature *sig = [self methodSignatureForSelector:@selector(a:b:c:)];
    NSInvocation *inv = [NSInvocation invocationWithMethodSignature:sig];

    [inv setTarget:self];
    [inv setSelector:@selector(a:b:c:)];

    NSString *a = @"a", *b = @"b", *c = @"c";
    [inv setArgument:&a atIndex:2];
    [inv setArgument:&b atIndex:3];
    [inv setArgument:&c atIndex:4];

    [inv retainArguments];
    [inv invoke];

    NSArray *ret;
    [inv getReturnValue:&ret];//this is problem,but why?
    NSLog(@"ret:%@", ret);
}

score 0 · Answer 1 · edited May 23 '17 at 12:29

I find answer in stackOverflow. The problem is getReturnValue:, it just copies the bytes of the return value into the given memory buffer, regardless of type. It doesn't know or care about memory management if the return type is a retainable object pointer type. Since ret is a __strong variable of object pointer type, ARC assumes that any value that has been put into the variable has been retained, and thus will release it when it goes out of scope. That is not true in this case, so it crashes. (Also, the array that had ret originally point to will be leaked, since getReturnValue: overwrites that value without releasing it. Why you even made that variable point to an object in the first place is beyond me.) NSInvocation returns value but makes app crash with EXC_BAD_ACCESS

NSInvocation trigger memory leak

1 Answers1