C++ replace all occurances of character in string

Question

I have a program in C++ in which all the input into the program has underscores('_') instead of spaces. I'm trying to replace all the underscores which spaces(' '). I tried using std::replace but I keep getting errors, I'm not sure where I'm getting it wrong.

int main()
{   
    string j = "This_is_a_test";

    j = std::replace( j.begin(), j.end(), '_', ' ');

    // I'm trying to get: This is a test from 'j',  
}

This is returning an error when I try compiling:

conversion from void' to non-scalar typestd::basic_string, std::allocator >' requested

Plus one: this is forgiveable if your normal language is Java. — Bathsheba, Oct 20 '15 at 11:43
@Bathsheba What? Java people don't know to look up documentation? Interesting... — juanchopanza, Oct 20 '15 at 11:44
@MelvinRufetu See the duplicate linked above. That has solutions to your problem. — juanchopanza, Oct 20 '15 at 11:47

score 4 · Accepted Answer · answered Oct 20 '15 at 11:41

4

std::replace works on iterators, so it modifies the string directly, without a necessary return value. Use

std::replace(j.begin(), j.end(), '_', ' ');

instead.

answered Oct 20 '15 at 11:41

cadaniluk

15,027
2
39
67

score 1 · Answer 2 · answered Oct 20 '15 at 11:41

1

std::replace returns void.

You can't assign void to std::string.

answered Oct 20 '15 at 11:41

Emil Laine

41,598
9
101
157

score 0 · Answer 3 · answered Oct 20 '15 at 11:42

0

You just have to use :

 std::replace( j.begin(), j.end(), '_', ' ');
 cout<<j;

answered Oct 20 '15 at 11:42

vishal

2,258
1
18
27

C++ replace all occurances of character in string

3 Answers3