PHP case not working with integer

Question

I have a strange case issue, in my php code;

$sm_hours = (int)$sm_hours;  // Make it an integer

echo $sm_hours;  // is 206

    switch ($sm_hours) {
        case ($sm_hours = 0 && $sm_hours <= 120):
            echo "One";
        break;
        case ($sm_hours >= 121 && $sm_hours <= 240):
            echo "Two";
        break;
        case ($sm_hours >= 241):
            echo "Three";
        break;
    }

$sm_hours is 206 but the echo I get is One not Two. What have I missed?

Thanks

try using intva($sm_hours); instead of casting (int) – Cr1xus Nov 21 '15 at 13:36 — Cr1xus, Nov 21 '15 at 13:36
try $sm_hours >= 0 && $sm_hours <=120 – Bug Hunter 219 Nov 21 '15 at 13:37 — Bug Hunter 219, Nov 21 '15 at 13:37
"=" is an assignment operator not comparison operator. – Amit Singh Nov 21 '15 at 13:39 — Amit Singh, Nov 21 '15 at 13:39

score 1 · Answer 1 · answered Nov 21 '15 at 13:37

1

You will always jump into the first switch case because you are setting $sm_hours to 0. A single = is used to set the variable.

To test its value use == which will perform type juggling, or use === to test the type also.

answered Nov 21 '15 at 13:37

Simian

814
11
21

score 1 · Answer 2 · answered Nov 21 '15 at 13:37

1

 case ($sm_hours == 0 && $sm_hours <= 120):

you are using equality operator

answered Nov 21 '15 at 13:37

undefined_variable

6,180
2
22
37

score 1 · Answer 3 · answered Nov 21 '15 at 13:37

1

In case one, try this:

case ($sm_hours == 0 && $sm_hours <= 120):
    echo "One";
break;

answered Nov 21 '15 at 13:37

user3461434

174
2
13

Great thanks.. I knew it was something simple, I just couldn't see it! – HeavyHead Nov 21 '15 at 13:40
in this case the first case will only be true if sm_hours is 0 – swidmann Nov 21 '15 at 13:41
@HeavyHead it won't work if 0 < $sum_hours < 120 . Try it – Bug Hunter 219 Nov 21 '15 at 13:43

WeSee · Answer 4 · 2015-11-21T13:47:12.923

1

Better use if and elseif statements in your case:

$sm_hours = (int)$sm_hours;  // Make it an integer
echo $sm_hours;  // is 206

if ($sm_hours >= 0 && $sm_hours <= 120)
    echo "One";
elseif ($sm_hours >= 121 && $sm_hours <= 240)
    echo "Two";
else
    echo "Three";

switch just tries to match exact values.

edited Nov 21 '15 at 13:47

answered Nov 21 '15 at 13:39

WeSee

3,158
2
30
58

score 0 · Answer 5 · answered Nov 21 '15 at 13:38

0

try

 $sm_hours >= 0 && $sm_hours <=120

answered Nov 21 '15 at 13:38

Bug Hunter 219

312
1
14

can you explain, why his code is not working? – swidmann Nov 21 '15 at 13:39
the switch statement gets converted to switch(260(boolean)) as int is a boolean value.In the first statement $variable gets updated to 0 which returns a boolean true and when it is compared with 120 it always evaluate to true as 0 < 120 and hence the boolean value becomes true and a match occurs and hence the condition is evaluated – Bug Hunter 219 Nov 21 '15 at 13:41
I thought you would point to the assignment instead of the comparision here: `sm_hours = 0` – swidmann Nov 21 '15 at 13:45
1

The solution that the OP has accepted is not logically correct . Consider when the value of variable is less than 120 and > 0 .Logically first condition nets to get accepted but it won't happen and hence it is logically flawed – Bug Hunter 219 Nov 21 '15 at 13:48

score 0 · Answer 6 · answered Nov 21 '15 at 15:27

Ok, so this works taking into account where $sm_hours is < 120 as pointed out by Anand. This code works for all options that I need.

     switch ($sm_hours) {
        case ($sm_hours >= 121 && $sm_hours <= 240):
            echo "Two";
        break;
        case ($sm_hours >= 241):
            echo "Three";
        break;
        default:
            echo "One";
        break;
     }

PHP case not working with integer

6 Answers6