regex java, unable to get the value

Question

Consider a String variable pri with value 07:45:32PM , now in order to obtain the PM alone I applied,

pri = pri.replaceAll("[^A-Z]","");

So far things work fine, but trying to compare the value in the variable does not work, ie :

   if(pri=="PM")
   {
        hh+=12;

   }

The body of the loop does not get executed. My question is are the two values different, ie Pri=="PM" , Why is it so? And how do I get to check my if loop in a precise way? Thank you

EDIT1

So I tried if(pri.equals("PM")) instead of if(pri=="PM") , but still it did not solve the problem!

Your code with that input works as expected for me when using `equals`. You must be doing something different which you haven't shown. — resueman, Nov 25 '15 at 16:07
For your actual problem, did you consider using something like [`new SimpleDateFormat("KK:mm:ssaa").parse(pri)`](http://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html)? — JimmyB, Nov 25 '15 at 16:10
Show your complete code (getting date string, replaceAll, comparing). Dump the value of pri, it might not be "PM" as you expect. — Werner Henze, Nov 25 '15 at 16:32

Perdomoff · Accepted Answer · 2015-11-25T16:04:48.623

1

EDIT: Use "equalsIgnoreCase()" method for comparing strings.

   if(pri.equalsIgnoreCase("PM"))
  {
    hh+=12;

   }

edited Nov 25 '15 at 16:04

answered Nov 25 '15 at 16:00

Perdomoff

938
2
7
26

You have a typo in your code: a missing `)` bracket at the end of the if clause – Phate01 Nov 25 '15 at 16:04
@Phate01, You're right, good catch thanks. – Perdomoff Nov 25 '15 at 16:05
1

Thanks, that worked, but why didnt just `pri.equals("PM")` work? – OBX Nov 25 '15 at 16:05
You can be more sure if you ignore the string case; in this situation it would have worked anyway – Phate01 Nov 25 '15 at 16:09
@Perdomoff you're welocme buddy – Phate01 Nov 25 '15 at 16:09
@oblivion, Because if pri is "pm", the equals() will return false, but equalsIgnoreCase() will return true. – Perdomoff Nov 25 '15 at 16:10

score 1 · Answer 2 · edited Nov 25 '15 at 17:38

1

You need to use .equals not == to compare two String Object.

    if(pri.equals("PM"))

edited Nov 25 '15 at 17:38

Dhaval Patel

10,119
5
43
46

answered Nov 25 '15 at 16:01

rainkinz

10,082
5
45
73

score 0 · Answer 3 · answered Nov 25 '15 at 16:03

0

Use if(pri.equals("PM")) instead.

answered Nov 25 '15 at 16:03

b han

28
5

regex java, unable to get the value

3 Answers3