PHP show message based on user had attach file or not attach file (part 3)

Question

Cont on. PHP show message based on user had attach file or not attach file (part 2)

Now, I want to show the error message on p tag when user didn't upload file 1 or file 2. Here is the code that I tried:

<html>
<head></head>
<body>
<p>
<?php
if(isset($_GET['action']) && ($_GET['action'])=='add')
{
     echo $errorMessage;
}
else
{
     echo ' ';
}
?>
</p> 

<form name="addform" method="post" action="add.php?action=add" enctype="multipart/form-data">
    File 1: <input type="file" name="file1" />
    File 2: <input type="file" name="file2" />
<input type="submit" name="submit" value="ADD">
</form>
</body>
</html>

<?php
if(isset($_GET['action']) && ($_GET['action'])=='add')
{
    UploadFile("file1","file2");
}

function UploadFile($file1, $file2)
{
    $file1Name = $_FILES[$file1]['name'];
    $file2Name = $_FILES[$file2]['name'];

    if(empty($file1Name) && empty($file2Name))
    {
        $errorMessage = 'Please upload file';
    }
}
?>

From above code, I get the following error:

Notice: Undefined variable: errorMessage on add.php in line 9

What mistakes am I made? How should I modify it?

where, in your code, do you define the variable `$errorMessage`? I had a look at the previous post you made and couldn't see it — Professor Abronsius, Dec 01 '15 at 08:03

score 2 · Accepted Answer · edited Dec 01 '15 at 08:38

2

you are using the variable before declaring and inititlizing, so keep the uploading part above like this

<html>
<head></head>

<body>
<p>
<?php
if(isset($_GET['action']) && ($_GET['action'])=='add')
{
    UploadFile("file1","file2");
}

function UploadFile($file1, $file2)
{
    $file1Name = $_FILES[$file1]['name'];
    $file2Name = $_FILES[$file2]['name'];

    if(empty($file1Name) && empty($file2Name))
    {
        $errorMessage = 'Please upload file';
    } else {
         $errorMessage = ''; 
    } 

    echo $errorMessage;
}     
?>
</p>

<form name="addform" method="post" action="add.php?action=add"     enctype="multipart/form-data">
File 1: <input type="file" name="file1" />
File 2: <input type="file" name="file2" />
<input type="submit" name="submit" value="ADD">
</form>
</body>
</html>

edited Dec 01 '15 at 08:38

KKL Michael

795
1
13
31

answered Dec 01 '15 at 08:03

Niranjan N Raju

12,047
4
22
41

function is pesent in saperate file?? – Niranjan N Raju Dec 01 '15 at 08:35
3

Add `return $errorMessage;` at end of UploadFile function, and modify line `UploadFile("file1","file2");` to `$errorMessage = UploadFile("file1","file2");` – Volvox Dec 01 '15 at 08:35
@Volvox thank you for this, – Niranjan N Raju Dec 01 '15 at 08:36
OK, problem solved. Really appreciate Raju and also the Volvox hint... – KKL Michael Dec 01 '15 at 08:41

score 1 · Answer 2 · answered Dec 01 '15 at 08:03

Modify, because you want to return the value of $errorMessage to be used again somewhere.

if(empty($file1Name) && empty($file2Name))
    {
        $errorMessage = 'Please upload file';
    }

to

if(empty($file1Name) && empty($file2Name))
    {
        $errorMessage = 'Please upload file';
    }
return $errorMessage ;

PHP show message based on user had attach file or not attach file (part 3)

2 Answers2