Why won't my PHP loop work properly?

Question

I am working on a social network project.

I have a table named member including information about each user: name, age, gender, and so on.

I am trying to display a default profile picture according to the user's gender.

<?php
$sql = "SELECT gender FROM member WHERE member_id = '$user_id'";
$result = $link->query($sql);

if ($result->num_rows > 0) {
    while ($row = $result->fetch_assoc()) {
        echo "gender is" . $row['gender'];
        if($row['gender'] ='female'){
?>

            <img src="..\img\female.png"  />

 <?php 
            break;
        }
        else if ($row['gender'] = 'male') {
 ?>
            <img src="..\img\male.png"  />

 <?php 
            break;
        }
    }
} 
?>

Now, the gender is being echoed out correctly, but it will always display a female's picture. What is it exactly that I am doing wrong?

score 2 · Accepted Answer · answered Dec 27 '15 at 09:04

2

Just make change in if statement, equal sign is two times to equate

           <? php
            if($row['gender'] =='female'){
            ?>

               <img src="..\img\female.png"  />

          <?php break;}

answered Dec 27 '15 at 09:04

Shahzad Barkati

2,532
6
25
33

Thank you very much, sir! You're a life-saver! :) – Deena Osman Dec 27 '15 at 09:12
Its glad... All the best @DeenaOsman – Shahzad Barkati Dec 27 '15 at 10:09

score 1 · Answer 2 · answered Dec 27 '15 at 09:04

The error is in your if statements. = is to assign and == is to compare. Try the following code:

<?php
$sql = "SELECT gender FROM member WHERE member_id = '$user_id'";
$result = $link->query($sql);

if ($result->num_rows > 0) {
    while($row = $result->fetch_assoc()) {
        echo "gender is".$row['gender'];
        if($row['gender'] =='female'){
            echo '<img src="..\img\female.png"  />';
            break;
        }
        else if($row['gender'] == 'male'){
            echo '<img src="..\img\male.png"  />';
            break;
        }
    }
}
?>

Naveed Khan · Answer 3 · 2015-12-27T11:27:02.537

1

= assigns right value to left variable. You're assigning value in if statement instead of comparing them. Your if statement should be

If($row["gender"]=="male"){
   // code
}

edited Dec 27 '15 at 11:27

answered Dec 27 '15 at 09:05

Naveed Khan

73
2
15

Please change it to, `if($row["gender"]=="male")` – Manikiran Dec 27 '15 at 09:09
Still not correct. variable names must start with `$`, so change `row` to `$row` – Manikiran Dec 27 '15 at 09:16
Man this app actually sucks and I hate typing – Naveed Khan Dec 27 '15 at 11:26

Why won't my PHP loop work properly?

3 Answers3