$(this).html() is not working when jquery version is v1.10.2

Question

the below code is a sample code where $(this).html() is not working when using jquery version v1.10.2 but the same code is working when jquery version is v1.6.4. see my code and give me suggestion how to get rid of this because our product is using jquery version v1.10.2.

$elements.each(function () {
    //alert($(this).text());
    if ($(this).html() === null) {

        $item = $('<li class="current" />').append($(this));
    }
    else {
        if (!isNaN(parseInt($(this).text()))) {
            $item = $('<li />').append($(this));

        }
        else {
            $item = $('<li class="navpage"/>').append($(this));
            //alert($(this).text());
        }
    }
    $list.append($item);
});

full code found in this js fiddle link https://jsfiddle.net/tridip/41s1pq3a/38/

just see & run the jsfiddle code with 2 different version called v1.6.4 and v1.10.2 then understand $(this).html() is not working.

looking for suggestion what i need to change in code as a result $(this).html() will start working in v1.10.2. thanks

dfsq · Accepted Answer · 2015-12-29T16:33:42.290

1

This comparison

if ($(this).html() === null) {
    $item = $('<li class="current" />').append($(this));
}

is too risky. And apparently it breaks in more recent version of jQuery. Just use

if (!$(this).html()) {
    $item = $('<li class="current" />').append($(this));
}

Demo: https://jsfiddle.net/41s1pq3a/40/

edited Dec 29 '15 at 16:33

answered Dec 29 '15 at 16:06

dfsq

191,768
25
236
258

The original comparison was `if ($(this).html() === null) {...` . Sorry for being a weisenheimer. ;-) – DavidDomain Dec 29 '15 at 16:31
@DavidDomain Thank you, this is important! – dfsq Dec 29 '15 at 16:34

score 0 · Answer 2 · edited May 23 '17 at 12:31

0

You are invoking the html function directly on TextNodes, a console.log from a $(this) inside the $elements.each returns:

<TextNode textContent="\n           1 \n            ">

This answer explains TextNodes well, and the reasons to operate on them. to Thus you should use the text function instead to get the string you want.

edited May 23 '17 at 12:31

Community

1
1

answered Dec 29 '15 at 16:12

Armfoot

4,663
5
45
60

$(this).html() is not working when jquery version is v1.10.2

2 Answers2