About reading file in c

Question

So i just got an assigment from my prof to make a program that would read or write a file . And i got some problem when reading an empty file , whenever i read an empty file it would input a space character and 0.0 . So is there any way to

Handle this ?

Here is my read code

void read()
{
    n = 0  ;     
    FILE *f ;

    f = fopen("namafile.txt","r");
    if (f)
    {
        while (!feof(f))
        {
            fscanf(f,"%[^|]|%[^#]#%f\n", mhs[n].nim, mhs[n].nama, &mhs[n].x) ;
            n++ ;
        }     
    }
    else
    {
        printf("file not found\n");
    }
    fclose(f) ;

}

sorry if its bad :D , i just a begginer hehe.. can you give me some suggestion how to write a good code ?? — triton21, Jan 09 '16 at 23:08
its kinda mix since my prof teach me C + C++ library and using c++ compiler — triton21, Jan 09 '16 at 23:09
Get a new prof. C and C++ are different languages. If you compile with a C++ compiler it is C++ and you should use C++ features. — too honest for this site, Jan 09 '16 at 23:18
they use visual c++ to compile c code and too many rule and some of em even said C++ isnt a language . — triton21, Jan 09 '16 at 23:24
On a side-note: you should [never use `while(!feof(file))`](http://stackoverflow.com/questions/5431941/why-is-while-feof-file-always-wrong). — Tim Čas, Jan 10 '16 at 00:19

score 1 · Answer 1 · answered Jan 09 '16 at 23:07

The EOF marker will be set after fscanf() fails, so you need a failing fscanf() in order for the loop to end. Also, you have to check if fscanf() succeeded for which you check it's return value, that said all you need is to change this

while (!feof(f))

to

while (fscanf(f,"%[^|]|%[^#]#%f\n", mhs[n].nim, mhs[n].nama, &mhs[n].x) == 3)

NOTE: Don't use identifiers like f, that's a bad habit that you can porbably justify if your IDE has no autocomplete feature, but it's hardly the case, you can name your identifier file instead to make it clear what it is.

About reading file in c

1 Answers1