Redirect doesn't works, it does nothing

Question

My header location doesn't works, in my wampserver it works, when I put it in my server, it doesn't, any Ideas?

If I put a echo instead of the header, it works fine.

<html>
    <head>
        <meta charset="utf-8">
        <title>Login</title>
        <link rel="stylesheet" href="css/login.css" />
    </head>
    <body>
    <?php
        require('db.php');

        session_start();

        // If form submitted, insert values into the database.
        if (isset($_POST['username'])){
            $username = $_POST['username'];
            $password = $_POST['password'];

            $username = stripslashes($username);
            $username = mysqli_real_escape_string($connection, $username);

            $password = stripslashes($password);
            $password = mysqli_real_escape_string($connection, $password);

            $query = "SELECT * FROM `users` WHERE username='$username' and password='$password'";
            $result = mysqli_query($connection, $query) or die(mysql_error());
            $rows = mysqli_num_rows( $result);
            if($rows==1){
                $_SESSION['username'] = $username;
                header("Location: welkom.php");
            }else{
                echo "<div id='cancel'><h3>Username/password is incorrect.</h3><br/>Click here to <a href='index.php'>try again</a></div>";
            }
        }else{   
    ?>
    <div id="login">
        <div id="triangle"></div>
        <h1>Log in</h1>
        <form action="" method="POST" name="login">
            <input type="text" name="username" placeholder="Username" required />
            <input type="password" name="password" placeholder="Password" required />
            <input name="submit" type="submit" value="login" />
        </form>
    </div>
    <?php } ?>
    </body>
</html>

If anything, make sure there is **no output whatsoever** before or after the location header and put a `die()` after it.... Your `sessions_start()` should also not work, because you already have output before the statement... — Raphioly-San, Jan 12 '16 at 09:55

Raphioly-San · Answer 1 · 2016-01-12T11:40:18.980

If anything, make sure there is no output whatsoever before or after the location header and put a die() after it.... Your sessions_start() should also not work, because you already have output before the statement...

So your session start and your location header should preceed the HTML.

Take a look at what I changed:

<?php
        require('db.php');

        session_start();

        // If form submitted, insert values into the database.
        if (isset($_POST['username'])){
            $username = $_POST['username'];
            $password = $_POST['password'];

            $username = stripslashes($username);
            $username = mysqli_real_escape_string($connection, $username);

            $password = stripslashes($password);
            $password = mysqli_real_escape_string($connection, $password);

            $query = "SELECT * FROM `users` WHERE username='$username' and password='$password'";
            $result = mysqli_query($connection, $query) or die(mysql_error());
            $rows = mysqli_num_rows( $result);
            if($rows==1){
                $_SESSION['username'] = $username;
                header("Location: welkom.php");
                die();
            }
<html>
    <head>
        <meta charset="utf-8">
        <title>Login</title>
        <link rel="stylesheet" href="css/login.css" />
    </head>
    <body>
    <?php
        if($rows!=1){
                echo "<div id='cancel'><h3>Username/password is incorrect.</h3><br />Click here to <a href='index.php'>try again</a></div>";

        }else{   
    ?>
    <div id="login">
        <div id="triangle"></div>
        <h1>Log in</h1>
        <form action="" method="POST" name="login">
            <input type="text" name="username" placeholder="Username" required />
            <input type="password" name="password" placeholder="Password" required />
            <input name="submit" type="submit" value="login" />
        </form>
    </div>
    <?php } ?>
    </body>
</html>

i put die() after it, still the same, should i do something else? you can check it in nuntravt.be/login user bart/ pass admin — Robert Verhaegen, Jan 12 '16 at 10:09

score 0 · Answer 2 · answered Jan 12 '16 at 09:58

You can't use header("Location: welkom.php"); where you are because headers have already been sent.

Either load all of the HTML in the page before that into a variable and then echo it once your code has come to that condition, or turn on Output Buffering.

Alternatively, re-order your code to check this condition and redirect before you send anything to the browser.

score 0 · Answer 3 · answered Jan 12 '16 at 10:28

0

Remove this :

header("Location: welkom.php");

And try this :

echo '<script>window.location.href = "welkom.php";</script>' ;

answered Jan 12 '16 at 10:28

user2460074

1,252
3
11
28

Okay, works perfect, Thank you! you make my day :) – Robert Verhaegen Jan 14 '16 at 07:48
@RobertVerhaegen Happy to help you can you please check my solution – user2460074 Jan 14 '16 at 08:47

score -1 · Answer 4 · answered Jan 12 '16 at 09:53

-1

Use full url in header location from i.e. header("Location: httP://yoursite.com/welkom.php"); that will work.

answered Jan 12 '16 at 09:53

Ajay Makwana

2,330
1
17
32

Even if the URL was supposedly wrong, it should still do the redirection. – Pierre-Loup Pagniez Jan 12 '16 at 09:54
did you get any error? – Ajay Makwana Jan 12 '16 at 09:57
i try did, it just goes to my index.php again, header("Location: http://nuntravt.be/login/welkom.php"); – Robert Verhaegen Jan 12 '16 at 10:00
It means header is working but something wrong. – Ajay Makwana Jan 12 '16 at 10:05
it displays an error `Parse error: syntax error, unexpected '}` – Ajay Makwana Jan 12 '16 at 10:06
try again, i put it back – Robert Verhaegen Jan 12 '16 at 10:16

Redirect doesn't works, it does nothing

4 Answers4