when i run this code it give error unexpected else please suggest mi how to write it

Question

when i run this code it give error unexpected else please suggest mi how to write it i am confused with open and close bracket

     <?php
     } 

     for ($i = $start_loop; $i <= $end_loop; $i++) 
     {

    //if ($cur_page == $i)
    if($i != $page)?>

     <a href="javascript:callonce_search( <?php echo $i?>,'<?php echo        $txt?>')"> $i </a>



  <?php 
    else
      echo " <a class='paginationcurrnt'><b> $i</b>";
     }


    // TO ENABLE THE NEXT BUTTON
   if ($next_btn && $cur_page < $no_of_paginations) 
    {
    $nex = $cur_page + 1; ?>

The code snippet as is appears to be incomplete. – mittmemo Jan 13 '16 at 13:59 — mittmemo, Jan 13 '16 at 13:59

score 0 · Answer 1 · answered Jan 13 '16 at 13:59

Curly braces are your friend when you want to explicitly define code blocks:

if($i != $page) { ?>
    <a href="javascript:callonce_search( <?php echo $i?>,'<?php echo        $txt?>')"> $i </a>
<?php 
} else {
    echo " <a class='paginationcurrnt'><b> $i</b>";
}

Sometimes, in the case of single-line code blocks, you can get away with not using them. But when mixing code with markup like this, the concept of "a line of code" becomes pretty effectively blurred. In that case, always explicitly use curly braces.

score 0 · Answer 2 · answered Jan 13 '16 at 14:00

This is very poorly written code. The syntax error is because your else comes out of nowhere. This is the format for if/else statements:

if(condition){
    //if condition is true
} else {
    //if condition is false
}

This is yours:

if(condition)
else
}

So change the if/else to:

if($i != $page) { ?>
    <a href="javascript:callonce_search( <?php echo $i?>,'<?php echo $txt ?>')"> $i </a>
<?php } else {
    echo " <a class='paginationcurrnt'><b> $i</b>";
}

when i run this code it give error unexpected else please suggest mi how to write it

2 Answers2