jQuery remove class but go to the link first

Question

I have a navigation menu that I need to hide after a link has been clicked. Here's my code:

jQuery("#nav a").click(function(e){
    e.preventDefault();
    var body = jQuery('body');
    if (body.hasClass('display-header'))
    {
        body.removeClass('display-header');
        jQuery('.overlay').fadeOut(200);
    }
});

The remove class works fine but the link won't go to the right section. (Imagine a single page with anchor links.)

How would you go about this?

Thank you.

What he means to say is `e.preventDefault()` will also stop the browser moving to a bookmark anchor. — iCollect.it Ltd, Jan 14 '16 at 14:51
Perfect. Thank you very much. I removed the prevent default and all is good :) — Chris.S, Jan 14 '16 at 15:10

score 1 · Answer 1 · edited May 23 '17 at 12:23

1

I think that you should try to use e.stopPropagation() for do what you want.

Read this answer: event.preventDefault() vs. return false

See you.

edited May 23 '17 at 12:23

Community

1
1

answered Jan 14 '16 at 15:03

Rodrigo Engelberg

51
3

This would depend solely on what was around the anchor, but there is no obvious reason to use `stopPropagation` here. Just removing `preventdefault()` would likely suffice. – iCollect.it Ltd Jan 14 '16 at 15:06
Perfect. Thank you very much. I removed the prevent default and all is good :) – Chris.S Jan 14 '16 at 15:10

JanivZ · Accepted Answer · 2016-01-31T13:33:50.400

0

Try removing the:

e.preventDefault();

and see if that helps.

from the documnetation : api.jquery.com/event.preventdefault/

"For example, clicked anchors will not take the browser to a new URL. We can use event.isDefaultPrevented() to determine if this method has been called by an event handler that was triggered by this event."

Also, if you could provide a full HTML & javascript example that reproduces your issue - it would help greatly !

edited Jan 31 '16 at 13:33

answered Jan 14 '16 at 15:04

JanivZ

2,265
3
25
31

Perfect. Thank you very much. I removed the prevent default and all is good :) – Chris.S Jan 14 '16 at 15:10

jQuery remove class but go to the link first

2 Answers2