Recycle view getting change while scrolling

Question

I am trying to change image in RecycleView dynamically. It will get changed successfully but when I scroll RecycleView ImageView will get change

Here is my adapter class code:

public class RecyclerViewAdapter extends RecyclerView.Adapter<RecyclerViewHolders> {
    private List<ItemObject> itemList;
    private Context context;
    OnGridSelected onGridObj;
    public RecyclerViewAdapter(Context context, List<ItemObject> itemList,OnGridSelected onGridObj) {
        this.itemList = itemList;
        this.context = context;
        this.onGridObj = onGridObj;
    }
    @Override
    public RecyclerViewHolders onCreateViewHolder(ViewGroup parent, int viewType) {
        View layoutView = LayoutInflater.from(parent.getContext()).inflate(R.layout.card_view_list, null);
        RecyclerViewHolders rcv = new RecyclerViewHolders(layoutView,itemList,onGridObj);
        return rcv;
    }
    @Override
    public void onBindViewHolder(RecyclerViewHolders holder, int position) {
        if(!itemList.get(position).isSelected()) {
            holder.countryName.setText(itemList.get(position).getName());
            holder.countryPhoto.setImageResource(itemList.get(position).getPhoto());
            itemList.get(position).setIsSelected(true);
        }
    }
    @Override
    public int getItemCount() {
        return this.itemList.size();
    }
}

How do I prevent recycle view getting recycle?

http://stackoverflow.com/questions/32065267/recyclerview-changing-items-during-scroll — IntelliJ Amiya, Jan 27 '16 at 08:40
@IntelliJAmiya I have set the flag in model but its not working. — Amy, Jan 27 '16 at 08:44

score 6 · Answer 1 · edited Jan 23 '17 at 08:18

6

Please try this:

If you are using RecycyclerView,override only getItemViewType method.

@Override
public int getItemViewType(int position) {
    return position;
}

edited Jan 23 '17 at 08:18

Satan Pandeya

3,747
4
27
53

answered Jan 23 '17 at 05:43

Amit gupta

107
1
3

awesome... just about when i was thinking to shift back to listviews.. thanks man.. :) – deejay Mar 30 '17 at 13:44
awesome thnxxxxx – Ravish Sharma Nov 29 '17 at 09:01

JAAD · Answer 2 · 2016-01-27T11:41:33.580

Please change

@Override
public void onBindViewHolder(RecyclerViewHolders holder, int position) {
    if(!itemList.get(position).isSelected()) {
        holder.countryName.setText(itemList.get(position).getName());
        holder.countryPhoto.setImageResource(itemList.get(position).getPhoto());
        itemList.get(position).setIsSelected(true);
    }
}

to

@Override
public void onBindViewHolder(RecyclerViewHolders holder, int position) {
        holder.countryName.setText(itemList.get(position).getName());
         holder.countryPhoto.setImageResource(itemList.get(position).getPhoto());
    }
}

and if you really need isSelected flag please use this:-

@Override
public void onBindViewHolder(RecyclerViewHolders holder, int position) {
    if(!itemList.get(position).isSelected()) {
        holder.countryName.setText(itemList.get(position).getName());
        holder.countryPhoto.setImageResource(itemList.get(position).getPhoto());
        itemList.get(position).setIsSelected(true);
    }else {
// specify here what to do when is selected is true
}
}

as onBindViewHolder is called each time a view is shown on screen so if isSelected is true it will never go into if condition and so the old data will be visible as recyclerview reuses views so u should specify what should be done when isSelected is true so that recyclerview can bind data to it

Recycle view getting change while scrolling

2 Answers2