jQuery ajax inside a loop

Question

I have two functions both of which makes a jQuery call , the first one gets the champion ID and the second one gets the champion name using the ID, now I have 10 champion names to get so I'm using a for loop but it just won't work ...
This is my code :

function GetChampName(id) {
  $.ajax({
    url: 'https://global.api.pvp.net/api/lol/static-data/euw/v1.2/champion/' + id + '?api_key=f8453a98-ad2c-455e-b9df-f46c4f99d0ed',
    datatype: 'json',
    type: 'get',
    success: function(json) {
      sName = json.name;
    }
  });
  return sName;
}

function summonerLookUp() {
  var cn = [];
  $.ajax({
    url: 'https://euw.api.pvp.net/api/lol/euw/v1.3/game/by-summoner/46743451/recent?api_key=f8453a98-ad2c-455e-b9df-f46c4f99d0ed',
    datatype: 'json',
    type: 'get',
    success: function(json) {
      for (var i = 0; i <= json.games.length; i++) {
        var id = json.games[i].championId;
        $('#t1 tr:last').after('<tr> <td>' + json.games[i].gameId + '</td><td id="e">' + cn[i] + '</td><td>' + wl(json.games[i].stats.win) + '</td> </tr>');
      }
    }
  });
}

why would you seperate out those requests, just send back the id and the name in the same request — johnny 5, Feb 04 '16 at 14:58
I'm new to this so I don't really know how to do that , I would appreciate some help . — Just Away, Feb 05 '16 at 00:55
do you own the website that your making your ajax request to? — johnny 5, Feb 05 '16 at 01:15
oh that sucks, you'll have to do it the shitty way by making all those request then, — johnny 5, Feb 05 '16 at 01:51

Eugene Hauptmann · Answer 1 · 2016-02-03T23:07:56.547

-1

function GetChampName(id,cb) {
  $.ajax({
    url: 'https://global.api.pvp.net/api/lol/static-data/euw/v1.2/champion/' + id + '?api_key=f8453a98-ad2c-455e-b9df-f46c4f99d0ed',
    datatype: 'json',
    type: 'get',
    success: function(json) {
      sName = json.name;
      cb(sName)
    }
  });
}

function summonerLookUp() {
  $.ajax({
    url: 'https://euw.api.pvp.net/api/lol/euw/v1.3/game/by-summoner/46743451/recent?api_key=f8453a98-ad2c-455e-b9df-f46c4f99d0ed',
    datatype: 'json',
    type: 'get',
    success: function(json) {
      for (var i = 0; i <= json.games.length; i++) {
        if(json.games[i]){
          var id = json.games[i].championId;
          GetChampName(id,function(sName){
            console.log(sName);
            var html = '<tr> <td>';
            html += json.games[i].gameId;
            html += '</td><td id="e">' + sName + '</td><td>';
            html += wl(json.games[i].stats.win);
            html += '</td> </tr>';
            $('#t1 tr:last').after(html);
          });
        }
      }
    }
  });
}

summonerLookUp();

edited Feb 03 '16 at 23:07

answered Feb 03 '16 at 22:53

Eugene Hauptmann

1,255
12
16

take a look, just updated the code. apparently not all games has values in it. – Eugene Hauptmann Feb 03 '16 at 23:08
if it still doesn't work for you, please show me the console output from your browser. thanks. – Eugene Hauptmann Feb 03 '16 at 23:29
Yea still not working I tried some other things but I failed , how do I link my console log ? – Just Away Feb 03 '16 at 23:45
just copy past, or send a screenshot please. – Eugene Hauptmann Feb 04 '16 at 00:03

jQuery ajax inside a loop

1 Answers1