How to skip empty lines without string class

Question

In the following code I can't use the std::string class.

I'm trying to read a file that has empty lines, and I want to ignore the empty lines when I encounter them.

I've tested out some ideas using a simplified example and a made-up text file containing empty lines.

int main() {
    ifstream fin;
    fin.open("test.txt");
    if(fin.fail()){
        cout << "Input file fail.";
        exit(-1);
    }

    char line[10];

    while(!fin.eof()){
       fin.getline(line, 10);
       if(line[0] == '\n')
           cout << "skip" << "\n"; 
       else
           cout << line << "\n";
    }
}

I've also tried things like strlen(line) == 1, but nothing worked so far.

What is the problem?

Please see [Why is iostream::eof inside a loop condition considered wrong?](http://stackoverflow.com/q/5605125/2069064) — Barry, Feb 13 '16 at 20:26
`std::getline()` discards the delimiter, which explains why neither of your solutions will work. — , Feb 13 '16 at 20:30
*We're not allowed to use the string class* -- So might as well call your course *C programming* instead of *C++ programming*. — PaulMcKenzie, Feb 13 '16 at 20:30
Teaching C++ while disallowing `std::string` is cruel and unusual. It would be a good idea to encourage your professor to [stop teaching C](https://www.youtube.com/watch?v=YnWhqhNdYyk). — Zulan, Feb 13 '16 at 20:34
@Barry Always a good notice when seeing that code, but not relevant for the particular case behavior. — πάντα ῥεῖ, Feb 13 '16 at 20:39

πάντα ῥεῖ · Accepted Answer · 2016-02-13T20:47:05.477

1

std::getline() already takes care of the '\n' character (it will be discarded), line[0] would contain '\0' in the case of an empty input.

Just compare for '\0' instead of '\n':

if(line[0] == '\0')
    cout << "skip" << "\n"; 
else
    cout << line << "\n";

I've also tried things like strlen(line) == 1

If so, shouldn't that have been strlen(line) == 0 for an empty line?

edited Feb 13 '16 at 20:47

answered Feb 13 '16 at 20:31

πάντα ῥεῖ

1
13
116
190

score 1 · Answer 2 · edited May 23 '17 at 12:23

There are two problems with your code. The first is that your loop isn't correct. You have to check the result of the getline() call, not eof(). Please see Why is iostream::eof inside a loop condition considered wrong. That restructured loop becomes:

while (fin.getline(line, 10)) {
    ...
}

Next, when you read a line with getline() (and 10 seems really short for a line), the delimiter will not be part of the body. There will not be a \n in line when you're doing reading. You'll just have an empty string. So the right way to discard empty lines is:

while (fin.getline(line, 10)) {
    if (line[0]) {
        // we have contents!
    }
}

Or really, std::string is just way better:

std::string line;
while (std::getline(fin, line)) {
    if (!line.empty()) {
        ....
    }
}

Zulan · Answer 3 · 2016-02-13T20:35:35.553

0

std::getline() discards the delimiter \n. But you might also want to consider that on some systems lines may be delimited by \r\n.

edited Feb 13 '16 at 20:35

answered Feb 13 '16 at 20:31

Zulan

21,896
6
49
109

`std::getline()` discards `\r\n` as well. – πάντα ῥεῖ Feb 13 '16 at 20:33
@πάνταῥεῖ Does it also if you transfer files between different systems? – Zulan Feb 13 '16 at 20:42

How to skip empty lines without string class

3 Answers3