ASP/Entity : Object Reference Error

Question

I have already have a look at such posts like: Object Reference Errors but still cannot find the answer I am looking for.

foreach (var test in (gathered as tblbus_address).Address1)

returns this error:

System.NullReferenceException: Object reference not set to an instance of an object.

I have tried checking if it is null before:

if(!string.IsNullOrEmpty((gathered as tblbus_address).Address1){}

I have tried adding ToString(); and making sure it is !=null;

However, even after all this, I receive the same error.

@Zippy gathered probably isn't a `tblbus_address`, then `as` returns null. — Alexander Derck, Feb 15 '16 at 10:47
@AlexanderDerck that can be true too. OP check if `gathered` is not null and if it's of type `tblbus_address` too. — Zippy, Feb 15 '16 at 10:48
@Zippy I added: `if (gathered != null && !string.IsNullOrEmpty((gathered as tblbus_address).Address1)){}` and nothing — Jaquarh, Feb 15 '16 at 10:50
@Zippy sure: `var gathered = (from c in db.tblbus_address where c.BusinessID == queryID && c.AddressTypeID == addrnum select c);` — Jaquarh, Feb 15 '16 at 10:52
Should be an Object of the Database showing all the data from the Query but I've stopped it and this is what it holds: https://gyazo.com/8474dc9eb382e923ae65e2a5d648fd9e — Jaquarh, Feb 15 '16 at 10:57

score 4 · Accepted Answer · answered Feb 15 '16 at 10:45

4

You are doing too many things in foreach statement. Rather split it up, this way you can neatly handle the null checks rather than getting the null reference exception.

var address = gathered as tblbus_address
if(address!=null && address.Address1 !=null)
{
  foreach (var test in address.Address1)
  {
    //do your stuff
  }
}

answered Feb 15 '16 at 10:45

Carbine

7,849
4
30
54

I will try this now, thank-you. – Jaquarh Feb 15 '16 at 10:50

score 1 · Answer 2 · answered Feb 15 '16 at 10:45

1

This should work for you

var data=gathered;
if(data!=null && !String.IsNullOrEmpty(data.Address1))
{
foreach (var test in (data as tblbus_address).Address1)
}

answered Feb 15 '16 at 10:45

Mir Gulam Sarwar

2,588
2
25
39

ASP/Entity : Object Reference Error

2 Answers2