Syntax Error, unexpected end of file - Can't see why

Question

Can somebody help me and explain me why I get this error with the following code, please:

<html>
    <head>
    </head>
    <body>
        <?php
            if (!(isset($_COOKIE["loggedin"]))){
                ?>
                <form action="<?php echo $_SERVER['PHP_SELF']?>" method="POST" name="name_form">
                    Username <input type="text" name="username">
                    <br/>
                    Password <input type="text" name="password">
                    <br/>
                    Remember Me <input type ="checkbox" name="remember_me" value="1">
                    <br/>
                    <input type="submit" name="submit" value="Log in">
                </form>
            }
    </body>
</html>

<?php

        if(preg_match("/<|>/", $_POST["username"])){    
            echo "do not log in";
        } 
        else if(preg_match("/<|>/", $_POST["password"])){   
            echo "do not log in";
        }
        else{
            //Open/create passwords.txt
            $passwordsFile = fopen("passwords.txt", "a");
            //write users username and password to passwords.txt
            $text_written = fwrite($passwordsFile, $_POST["username"] . "," . $_POST["password"] . "\r\n");
            fclose($passwordsFile);
            setcookie("loggedin", $_POST['username']);
            setcookie("loggedintime", time());
        }
    ?>

Thanks in advance for the help! I've seen similar posts around here but I wasn't able to solve this anyway...

The `}` between the closing tags of the form and body is not enclosed in `` — Max, Feb 17 '16 at 11:34

Francis Laclé · Accepted Answer · 2016-02-17T11:42:46.053

It seems you have an extra curly bracket at the end just before the closing PHP tag ?> and you forgot to wrap the previous end curly bracket } of the IF-statement: if (!(isset($_COOKIE["loggedin"]))){ with PHP closing and ending tags, correct code:

<html>
  <head>
  </head>
  <body>
    <?php if (!(isset($_COOKIE["loggedin"]))){ ?>
      <form action="<?php echo $_SERVER['PHP_SELF']?>" method="POST" name="name_form">
          Username <input type="text" name="username">
          <br/>
          Password <input type="text" name="password">
          <br/>
          Remember Me <input type ="checkbox" name="remember_me" value="1">
          <br/>
          <input type="submit" name="submit" value="Log in">
      </form>
    <?php } ?>
  </body>
</html>
<?php
  if(preg_match("/<|>/", $_POST["username"])){
    echo "do not log in";
  }
  else if(preg_match("/<|>/", $_POST["password"])){
    echo "do not log in";
  }
  else{
    //Open/create passwords.txt
    $passwordsFile = fopen("passwords.txt", "a");
    //write users username and password to passwords.txt
    $text_written = fwrite($passwordsFile, $_POST["username"] . "," . $_POST["password"] . "\r\n");
    fclose($passwordsFile);
    setcookie("loggedin", $_POST['username']);
    setcookie("loggedintime", time());
  }
?>

already fixed that befor, but didn't work... I've paste ir wrong — Fodrigoal, Feb 17 '16 at 11:35
thanks @flacle! I didn't know that the php closing tag should come before the }! — Fodrigoal, Feb 17 '16 at 11:40
@Fodrigoal no problem, glad the answer worked for your issue :) — Francis Laclé, Feb 17 '16 at 11:43

score 1 · Answer 2 · answered Feb 17 '16 at 11:38

complete the if brace in php block..

<html>
<head>
</head>
<body>
    <?php
        if (!(isset($_COOKIE["loggedin"]))){
            ?>
            <form action="<?php echo $_SERVER['PHP_SELF']?>" method="POST" name="name_form">
                Username <input type="text" name="username">
                <br/>
                Password <input type="text" name="password">
                <br/>
                Remember Me <input type ="checkbox" name="remember_me" value="1">
                <br/>
                <input type="submit" name="submit" value="Log in">
            </form>
       <?php  } ?>
</body>

score 1 · Answer 3 · answered Feb 17 '16 at 11:43

I have made few changes in your code, The close bracket for first if condition is not with in the php tag(<?php ... ?> ). Try to give the password.txt file read write permission

<html>
    <head>
    </head>
    <body>
        <?php
        if (!isset($_COOKIE["loggedin"])) {
            ?>
            <form action="<?php echo $_SERVER['PHP_SELF'] ?>" method="POST" name="name_form">
                Username <input type="text" name="username">
                <br/>
                Password <input type="text" name="password">
                <br/>
                Remember Me <input type ="checkbox" name="remember_me" value="1">
                <br/>
                <input type="submit" name="submit" value="Log in">
            </form>
        <?php } ?>
    </body>
</html>

<?php
if (!empty($_POST['submit'])) {
    if (preg_match("/<|>/", $_POST["username"])) {
        echo "do not log in";
    } else if (preg_match("/<|>/", $_POST["password"])) {
        echo "do not log in";
    } else {
        //Open/create passwords.txt
        $passwordsFile = fopen("passwords.txt", "a");
        //write users username and password to passwords.txt
        $text_written = fwrite($passwordsFile, $_POST["username"] . "," . $_POST["password"] . "\r\n");
        fclose($passwordsFile);
        setcookie("loggedin", $_POST['username']);
        setcookie("loggedintime", time());
    }
}
?>

score 1 · Answer 4 · answered Feb 17 '16 at 11:43

1

Try

 if (!isset($_COOKIE["loggedin"])){

Instead of

 if (!(isset($_COOKIE["loggedin"]))){

answered Feb 17 '16 at 11:43

Dr Manish Lataa-Manohar Joshi

2,380
5
17
38

Syntax Error, unexpected end of file - Can't see why

4 Answers4