Android "Taking Photos Simply" tutorial does not work for me

Question

So, I am trying to implement taking of photos in my app.

I am following the official "Taking Photos Simply" tutorial, but it just gives me errors.

The only thing I am doing differently, it that I am using a popup dialog fragment.

Below is the error I get:

java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=131073, result=-1, data=null} to activity {com.myapp.demo/com.myapp.demo.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Bundle android.content.Intent.getExtras()' on a null object reference
        at android.app.ActivityThread.deliverResults(ActivityThread.java:3605)
        at android.app.ActivityThread.handleSendResult(ActivityThread.java:3648)
        at android.app.ActivityThread.access$1400(ActivityThread.java:154)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1370)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:135)
        at android.app.ActivityThread.main(ActivityThread.java:5289)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)
 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Bundle android.content.Intent.getExtras()' on a null object reference
        at com.paulcanning.mote.NoteDialogFragment.onActivityResult(NoteDialogFragment.java:179)
        at android.support.v4.app.FragmentActivity.onActivityResult(FragmentActivity.java:153)
        at android.app.Activity.dispatchActivityResult(Activity.java:6192)
        at android.app.ActivityThread.deliverResults(ActivityThread.java:3601)
            at android.app.ActivityThread.handleSendResult(ActivityThread.java:3648)
            at android.app.ActivityThread.access$1400(ActivityThread.java:154)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1370)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:135)
            at android.app.ActivityThread.main(ActivityThread.java:5289)
            at java.lang.reflect.Method.invoke(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:372)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)

Button click listener

takePhoto.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
            if (takePictureIntent.resolveActivity(getContext().getPackageManager()) != null) {
                //startActivityForResult(takePictureIntent, 1);

                File photoFile = null;
                try {
                    photoFile = createImageFile();
                } catch (IOException ex) {
                    // Error occurred while creating the File
                }
                // Continue only if the File was successfully created
                if (photoFile != null) {
                    takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT,
                            Uri.fromFile(photoFile));
                    startActivityForResult(takePictureIntent, 1);
                }
            }
        }

    });

onActivityResult (note, it wouldn't let me use protected)

@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
    if (requestCode == 1 && resultCode == getActivity().RESULT_OK) {
        Bundle extras = data.getExtras();
        Bitmap imageBitmap = (Bitmap) extras.get("data");
        imageView.setImageBitmap(imageBitmap);
    }
}

Please provide a [mcve], which in this case would be the source of `NoteDialogFragment`, particularly the `onActivityResult()` method. Also, be sure to show where you are calling `startActivityForResult()`. — CommonsWare, Feb 18 '16 at 18:35
@Rami not really. I'm not asking how to solve NullPointers, but why the official tutorial is not working — Mr Pablo, Feb 18 '16 at 18:38
I had similar problem and the error was in `createImageFile` where this line created the problem: `mCurrentPhotoPath = "file:" + image.getAbsolutePath();` i Had to remove the `"file:"` prefix — Giorgio Andretti, May 02 '16 at 16:07

score 0 · Accepted Answer · answered Feb 18 '16 at 18:42

0

You are supplying EXTRA_OUTPUT. Hence, camera apps do not need to supply getExtra("data"), so it will generally be null.

Quoting the documentation for ACTION_IMAGE_CAPTURE:

The caller may pass an extra EXTRA_OUTPUT to control where this image will be written. If the EXTRA_OUTPUT is not present, then a small sized image is returned as a Bitmap object in the extra field. This is useful for applications that only need a small image. If the EXTRA_OUTPUT is present, then the full-sized image will be written to the Uri value of EXTRA_OUTPUT.

Your image (hopefully) is in the location that you supplied in EXTRA_OUTPUT.

answered Feb 18 '16 at 18:42

CommonsWare

986,068
189
2,389
2,491

So how would I go about fetching the image from the extra_output / uri in `onActivityResult`? – Mr Pablo Feb 18 '16 at 20:34
@MrPablo: Hold onto `photoFile`, including across configuration changes. Then, use your favorite [image-loading library](http://android-arsenal.com/tag/46) to load the image into your `ImageView`. – CommonsWare Feb 18 '16 at 20:40
But in this instance? How do I get photoFile in the activity result? – Mr Pablo Feb 18 '16 at 20:50
@MrPablo: Um, use a field. – CommonsWare Feb 18 '16 at 20:53
1

Right, sorry but I'm really not following you. I read your answer and that makes sense. But how exactly do I get the image from the extra_output variable? Can you show me a code snippet? – Mr Pablo Feb 18 '16 at 21:37
@MrPablo: https://stackoverflow.com/questions/35394340/camera-intent-return-null-only-on-some-devices/35394405#35394405 – CommonsWare Feb 18 '16 at 21:40
Thanks, I'll give it a go tomorrow – Mr Pablo Feb 18 '16 at 23:32

Android "Taking Photos Simply" tutorial does not work for me

1 Answers1

Related