Unexpected 'endforeach' in code

Question

Below are lines of my code. I have a foreach loop to print values into a table. It results in an error saying

"Parse error: syntax error, unexpected 'endforeach' (T_ENDFOREACH)"

I can't seem to figure out where I have gone wrong.

<?php foreach (getStaffDetails() as $staffDetails): 
if($staffDetails['admin_confirm'] == 1) 
  {?>
  <tr>                             
  <td><?php echo $staffDetails['name']; ?></td>                               
  <td> <?php echo $staffDetails['staff_id']; ?></td>
  <td> <?php $dept= $staffDetails['dept_id']; 
            $dept_name= getDeptName($dept);
            echo $dept_name;?> </td> 
  <td> <?php echo $staffDetails['email_id']; ?></td>
  <td> <?php echo $staffDetails['ph_no']; ?></td>
  <td> <?php echo $staffDetails['gender']; ?></td>
  <td> <?php echo $staffDetails['doj']; ?></td> 
<?php endforeach; ?>

Panda · Accepted Answer · 2016-02-21T09:18:02.933

1

You've opened a curly bracket at but did not close it.

if($staffDetails['admin_confirm'] == 1) 
    {?>

You'll need to close it here:

<td> <?php echo $staffDetails['doj']; ?></td> 
<?php } endforeach; ?>

edited Feb 21 '16 at 09:18

answered Feb 21 '16 at 06:53

Panda

6,955
6
40
55

I think he wants to close it *before* the `endforeach`. – Sergey Vidusov Feb 21 '16 at 07:15
@SergeyVidusov Yup, just realised it, thanks for pointing it out :) – Panda Feb 21 '16 at 07:15

score 0 · Answer 2 · answered Feb 21 '16 at 08:05

This is because the if statement is not closed in your code. Therefore, the PHP parser encounters the endforeach keyword before the closing of the if statement

<?php 
  foreach (getStaffDetails() as $staffDetails): 
      if($staffDetails['admin_confirm'] == 1):
?>
<tr>                             
    <td> <?php echo $staffDetails['name']; ?> </td>                               
    <td> <?php echo $staffDetails['staff_id']; ?> </td>
    <td> <?php $dept= $staffDetails['dept_id']; 
               $dept_name= getDeptName($dept);
               echo $dept_name;?> </td> 
    <td> <?php echo $staffDetails['email_id']; ?> </td>
    <td> <?php echo $staffDetails['ph_no']; ?> </td>
    <td> <?php echo $staffDetails['gender']; ?> </td>
    <td> <?php echo $staffDetails['doj']; ?> </td> 
</tr>
<?php 
      endif;
  endforeach; ?>

Unexpected 'endforeach' in code

2 Answers2