Incompatible Objective-C types initializing 'struct NSNumber ', expected 'struct NSDecimalNumber '

Question

I have the below method in my project, and I get a compiler warning: Incompatible Objective-C types initializing 'struct NSNumber *', expected 'struct NSDecimalNumber * on the first line:

- (IBAction)sliderValueChanged:(id)sender {
    // HERE IS WHERE THE WARNING OCCURS:
    NSDecimalNumber *tempNumber = [NSDecimalNumber numberWithFloat:[self.slider value]];

    NSDecimalNumberHandler *roundingStyle = [NSDecimalNumberHandler decimalNumberHandlerWithRoundingMode:NSRoundBankers
                                                                                                   scale:3 
                                                                                        raiseOnExactness:NO
                                                                                         raiseOnOverflow:NO 
                                                                                        raiseOnUnderflow:NO 
                                                                                     raiseOnDivideByZero:NO];
    NSDecimalNumber *roundedNumber = [tempNumber decimalNumberByRoundingAccordingToBehavior:roundingStyle];
    self.slider.value = [roundedNumber floatValue];


    // Set up the percentage formatter
    NSNumberFormatter *percentFormatter = [[NSNumberFormatter alloc] init];
    [percentFormatter setNumberStyle:NSNumberFormatterPercentStyle];
    [percentFormatter setMinimumFractionDigits:1];
    [percentFormatter setMaximumFractionDigits:1];

    // Find the label to update
    NSUInteger onlyRow[] = {0, 0};
    NSIndexPath *onlyRowPath = [NSIndexPath indexPathWithIndexes:onlyRow length:2];
    UITableViewCell *cell = [self.tableView cellForRowAtIndexPath:onlyRowPath];
    UILabel *theLabel = (UILabel *)[cell.contentView viewWithTag:kLabelFieldTag];

    NSNumber *theNumber = [NSNumber numberWithFloat:self.slider.value];
    theLabel.text = [percentFormatter stringFromNumber:theNumber];

    [percentFormatter release];
}

Any help would be appreciated, thanks!

score 2 · Answer 1 · answered Aug 25 '10 at 15:11

2

numberWithFloat method returns a NSNumber instance. Just typecasting it to NSDecimalNUmber might resolve the warning.

NSDecimalNumber *tempNumber = (NSDecimalNumber *)[NSDecimalNumber numberWithFloat:[self.slider value]];

answered Aug 25 '10 at 15:11

Swapnil Luktuke

10,385
2
35
58

score 2 · Accepted Answer · answered Aug 25 '10 at 15:14

2

The method numberWithFloat is said (in the header) to always returns an NSNumber object. Sending the method to a subclass still returns an NSNumber object. I don't know NSDecimalNumber in detail, but I see several approaches to the problem here:

(dirty) you might try to cast the result to (NSDecimalNumber *) and see if it works
(clean) use one of NSDecimalNumbers initializers, like + decimalNumberWithString:
(best) Shift your method to use NSNumber and a NSNumberFormatter only, this supports different rounding behaviors as well

answered Aug 25 '10 at 15:14

Max Seelemann

9,344
4
34
40

method 1 works, (`[[NSDecimalNumber numberWithFloat:2] class]` is NSDecimalNumber) – cobbal Aug 25 '10 at 15:18
Okay, good to hear, but I'd still stick to a different method. The static cast in the NSNumber headers is definitely a problem here... – Max Seelemann Aug 25 '10 at 15:20
@cobbal - Actually, that can introduce floating-point issues, so I'd recommend number 2 on the list if you wish to avoid this. See this question for an example of what can go wrong: http://stackoverflow.com/questions/2479100/cocoa-ive-discovered-what-i-think-is-a-bug-with-nsdecimalnumber – Brad Larson Aug 25 '10 at 19:18

Incompatible Objective-C types initializing 'struct NSNumber *', expected 'struct NSDecimalNumber *'

2 Answers2

Incompatible Objective-C types initializing 'struct NSNumber ', expected 'struct NSDecimalNumber '