Updating Log-out record not working

Question

I'm currently working on a log-out system, which will record users when they logged out. But it's not updating properly.

Code:

<?php
include('global.php');
        $sql="SELECT * FROM $tbl_name WHERE username='$myusername' and 
        password='$mypassword'";
    $result=mysql_query($sql);
    while($row=mysql_fetch_array($result))

        {
    $logintime=$row['logintime'];
    }


        if(mysql_num_rows($result))
        {

        $query = "UPDATE time_tb SET ";


            $query = $query."logoutime='".$p_time."' ";

            $query = $query."WHERE logintime='".$logintime."'"; 

            ExecuteQuery($query);




session_destroy();
header ("location: loginadmin.php");
            }
?>

Please dont use the `mysql_` database extension, it is deprecated (gone for ever in PHP7) Especially if you are just learning PHP, spend your energies learning the `PDO` or `mysqli_` database extensions, [and here is some help to decide which to use](http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php) — RiggsFolly, Mar 01 '16 at 13:44
Why bother setting `$_SESSION` if you are logging them out? What is `$p_time`? What data type is `logoutime`? Are there any errors? You also may be open to SQL injections depending on how those initial values are set.. — chris85, Mar 01 '16 at 13:45
where are the variables `$tbl_name`, `$myusername`, and `$mypassword` coming from? are they all set in `global.php`? — CodeGodie, Mar 01 '16 at 13:50
@chris85, i have already made a global variable p_time which is time. — codeSeven, Mar 01 '16 at 13:50
you need a semicolon `;` after `header("location: loginadmin.php")` — CodeGodie, Mar 01 '16 at 13:53
i believe `mysql_num_rows` will only output the number of rows in your result, not the actual rows. Youre going to need a `while` loop to fetch your results — CodeGodie, Mar 01 '16 at 13:56
Im a bit confused in your flow. It seems that your `$tbl_name` already has a column that tracks updated times in `logintime` How is that column updated? Why not update that table and the `time_tb` table at the same time? — CodeGodie, Mar 01 '16 at 14:05
why are you setting your `$_SESSION` variables, if you will destroy them `session_destroy()` right after? — CodeGodie, Mar 01 '16 at 14:11
i have already made a debug still not working. please see above code — codeSeven, Mar 01 '16 at 15:28
@CodeGodie `$query = $query.` shouldn't be overwritten, should be appended. — chris85, Mar 01 '16 at 15:39
@chris85 you are right, I was looking for the short way `.=` but that concatenation does work as well. Thanks for pointing that out. — CodeGodie, Mar 01 '16 at 15:41
What is `ExecuteQuery`? Do you have anything in your error logs? Are you checking error logs? — chris85, Mar 01 '16 at 15:41
they are no errors, but it is not updating on the table. i just need to update the logoutime row but its not. — codeSeven, Mar 01 '16 at 15:48
Do you have error reporting on? What does `its working to me` mean? — chris85, Mar 01 '16 at 15:51
i mean the query=$query. work well , but the problem is my table is not updating. — codeSeven, Mar 01 '16 at 15:55

score 0 · Answer 1 · edited Mar 02 '16 at 08:10

0

try this

 $query = "UPDATE time_tb SET ";
 $query.="logoutime=".$p_time." WHERE logintime=".$logintime;

And yes you should check your sql query in console by using print_r or others in your code.

edited Mar 02 '16 at 08:10

urfusion

5,528
5
50
87

answered Mar 02 '16 at 05:04

bhavik shah

45
8

Updating Log-out record not working

1 Answers1