NullPointerException when using Handler for updating progressBar

Question

public class MainActivity extends Activity {

    Button button = (Button)findViewById(R.id.btn);
    ProgressBar bar = (ProgressBar)findViewById(R.id.pbar);

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);


        button.setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View v) {
                // TODO Auto-generated method stub
                updateHandler.post(updateThread);
            }
        });

    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();
        if (id == R.id.action_settings) {
            return true;
        }
        return super.onOptionsItemSelected(item);
    }


     Handler updateHandler = new Handler(){

        public void handleMessage(Message msg) {
            bar.setProgress(msg.arg1);
            updateHandler.post(updateThread);
        };
    };

    Runnable updateThread  = new Runnable() {

        int i = 0;
        @Override
        public void run() {
            // TODO Auto-generated method stub
            System.out.println("------------");
            i = i+10;
            Message msg = updateHandler.obtainMessage();
            msg.arg1 = i;

            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }

            updateHandler.sendMessage(msg);
            if (i==100) {
                updateHandler.removeCallbacks(updateThread);
            }
        }
    };


}

Logcat:

java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.zxy.handlerpbtest/com.zxy.handlerpbtest.MainActivity}: java.lang.NullPointerException

ContentView while creation of activity didn't get initialization by findViewById() method so that is necessary to declare it globally/localy & initialized in onCreate() activity. — Ajinkya, Mar 05 '16 at 06:16

score 0 · Answer 1 · answered Mar 05 '16 at 05:16

0

This line

ProgressBar bar = (ProgressBar)findViewById(R.id.pbar);
Button button = (Button)findViewById(R.id.btn);

should be in your onCreate method

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    ProgressBar bar = (ProgressBar)findViewById(R.id.pbar);
    Button button = (Button)findViewById(R.id.btn);
}

answered Mar 05 '16 at 05:16

Inducesmile

2,475
1
17
19

！thx ！ I'm so careless – zxinyan Mar 07 '16 at 03:32

score 0 · Accepted Answer · answered Mar 05 '16 at 05:45

0

You can rewrite this code of lines:

ProgressBar bar = (ProgressBar)findViewById(R.id.pbar);
Button button = (Button)findViewById(R.id.btn);

As:

public class MainActivity extends Activity {

    Button button ;
    ProgressBar bar ;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        bar = (ProgressBar)findViewById(R.id.pbar);
        button = (Button)findViewById(R.id.btn);
.....
}}

Then you will not get null pointer exception.

answered Mar 05 '16 at 05:45

Android Geek

8,956
2
21
35

thank you so much ,I didnt notice that before – zxinyan Mar 07 '16 at 03:33
@Z.xinyan95 if this helped you can accept my answer. :) Thanks :) – Android Geek Mar 07 '16 at 04:14

score 0 · Answer 3 · answered Mar 05 '16 at 06:02

Here is Complete Solution :

public class MainActivity extends Activity {

    Button button;
    ProgressBar bar;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main2);

        button = (Button) findViewById(R.id.btn);
        bar = (ProgressBar) findViewById(R.id.pbar);

        button.setOnClickListener(new View.OnClickListener() {

            @Override
            public void onClick(View v) {
                // TODO Auto-generated method stub
                updateHandler.post(updateThread);
            }
        });

    }


    Handler updateHandler = new Handler() {

        public void handleMessage(Message msg) {
            bar.setProgress(msg.arg1);
            updateHandler.post(updateThread);
        }
    };

    Runnable updateThread = new Runnable() {

        int i = 0;

        @Override
        public void run() {
            // TODO Auto-generated method stub
            System.out.println("------------");
            i = i + 10;
            Message msg = updateHandler.obtainMessage();
            msg.arg1 = i;

            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }

            updateHandler.sendMessage(msg);
            if (i == 100) {
                updateHandler.removeCallbacks(updateThread);
            }
        }
    };

}

NullPointerException when using Handler for updating progressBar

3 Answers3