How to send parameter to where clause in a Sqlite query

Question

I'm trying to get a single row from database.But it is not generated query. The questions marks still seems. What am i missing ?

 public static User getSingleUser(String email,String password)
    {
        User user = new User();

        SQLiteDatabase db = DatabaseManager.getInstance().openDatabase();

        String selectQuery = " SELECT * FROM " + User.TABLE + " WHERE "
                + User.KEY_EMAIL + "=?"+ " AND " + User.KEY_PASSWORD
                + "=?" ;

        Cursor cursor = db.rawQuery(selectQuery,new String[]{email,password},null);

        if (cursor.moveToFirst()) {
            do {

                user.setId(cursor.getInt(cursor.getColumnIndex("UserId")));
                user.setFirstname(cursor.getString(cursor.getColumnIndex("Firstname")));
                user.setLastname(cursor.getString(cursor.getColumnIndex("Lastname")));
                user.setEmail(cursor.getString(cursor.getColumnIndex("Email")));
                user.setPassword(cursor.getString(cursor.getColumnIndex("Password")));
                user.setIsActive(cursor.getInt(cursor.getColumnIndex("IsActive")));

            } while (cursor.moveToNext());
        }

        return user;
    }
}

what do you mean? is the cursor empty? maybe the db table is empty? — pskink, Mar 18 '16 at 09:06
selectQuery = SELECT * FROM User WHERE Email=? AND Password=? and in cursor mQuery is SQLiteQuery: SELECT * FROM User WHERE Email=? AND Password=? — Trinity, Mar 18 '16 at 09:13
what is your problem actually? did you check the cursor content? — pskink, Mar 18 '16 at 09:14
why are you looping in if statement.. And what happened after continuous settings values to the user object in looping ? What is the purpose of that ? — Shree Krishna, Mar 18 '16 at 09:17
cursor is not empty but my query as i wrote before still question marks are coming up with — Trinity, Mar 18 '16 at 09:18

score 2 · Accepted Answer · answered Mar 18 '16 at 09:07

2

Try this,

    String selection = User.KEY_EMAIL + "=?"+ " AND " + User.KEY_PASSWORD + "=?";
    String[] selectionArgs = new String[]{ email, password };
    Cursor cursor = db.query(User.TABLE, null, selection, selectionArgs, null, null, null);

answered Mar 18 '16 at 09:07

K Neeraj Lal

6,768
3
24
33

score 0 · Answer 2 · answered Mar 18 '16 at 09:09

0

try to use native android query as below -

Cursor cursor = db.query(User.TABLE, null, User.KEY_EMAIL + "=? and " + User.KEY_PASSWORD + "=?", new String[] {email, password}, null, null, null );

answered Mar 18 '16 at 09:09

kevz

2,727
14
39

@Timosis: I find it easy to use that way. – kevz Mar 18 '16 at 09:21
@Timosis: you may check these link for performance http://stackoverflow.com/questions/8830753/android-sqlite-which-query-query-or-rawquery-is-faster and http://stackoverflow.com/questions/8435932/rawquery-vs-database-query – kevz Mar 18 '16 at 09:25

How to send parameter to where clause in a Sqlite query

2 Answers2