No variable member function declared in class?

Question

can sombody explain to me why my code will not work, and how to fix it thanks :)

I keep recieving this error :

no 'int burrito::setName()' member function declared in class 'burrito'

My goal is to call a function from a different class file

My main.cpp :

#include <iostream>
#include "burrito.h"
using namespace std;

int main()
{

burrito a;
a.setName("Ammar T.");


return 0;
}

My class header (burrito.h)

#ifndef BURRITO_H
#define BURRITO_H


class burrito
{
public:
    burrito();
};

#endif // BURRITO_H

My class file (burrito.cpp):

#include "burrito.h"
#include <iostream>

using namespace std;

burrito::setName()
{
  public:
    void setName(string x){
        name = x;


    };
burrito::getName(){

    string getName(){
        return name;
    };

}

burrito::variables(string name){
    string name;
               };

private:
    string name;
};

You need to define all the functions in the header and in the cpp. Google a sample header program — Khalil Khalaf, Apr 06 '16 at 23:13
Your burrito has no variables (data members) declared in the class. Your `variables` method has *local* variables that disappear after execution leaves the method. — Thomas Matthews, Apr 06 '16 at 23:19
Your source file has `private` section and `};` not associated with anything. Maybe you wanted to move these lines to the end of your Burrito. — Thomas Matthews, Apr 06 '16 at 23:20

Khalil Khalaf · Accepted Answer · 2016-04-06T23:35:58.980

1

Your code is a mess. You need to write function prototypes in the header file and function definitions in the cpp file. You are missing some basic coding structures. See below and learn this pattern of coding:

This code should work and enjoy burritos !

main():

#include <iostream>
#include "Header.h"

int main()
{
    burrito a;
    a.setName("Ammar T.");

    std::cout << a.getName() << "\n";

    getchar();
    return 0;
}

CPP file:

#include "Header.h"
#include <string>

void burrito::setName(std::string x) { this->name = x; }
std::string burrito::getName() { return this->name; }

Header file:

#include <string>

class burrito
{
private:
    std::string name;

public:
    void setName(std::string);
    std::string getName();
    //variables(string name) {string name;} // What do you mean by this??
};

edited Apr 06 '16 at 23:35

answered Apr 06 '16 at 23:24

Khalil Khalaf

9,259
11
62
104

Thanks for this! Sorry for this mess, I'm new to c++ – Ammar T. Apr 06 '16 at 23:26
A common coding guideline is to provide parameter names in the declarations of methods. – Thomas Matthews Apr 06 '16 at 23:26
@AmmarT glad it helped. Please mark it as an answer if you see it working :) – Khalil Khalaf Apr 06 '16 at 23:29
Do NOT put `using namespace std;` in the header file, this creates namespace pollution - see here: http://stackoverflow.com/questions/1452721/why-is-using-namespace-std-in-c-considered-bad-practice – sjrowlinson Apr 06 '16 at 23:31
But this is for beginners? @archbishopofbanterbury – Khalil Khalaf Apr 06 '16 at 23:33
@FirstStep That does not mean that we should teach them poor coding conventions - it's best to learn good coding conventions right from the start – sjrowlinson Apr 06 '16 at 23:34
You are making a point. I learned it that way and I am fairly doing good now. Thanks for the point I edited it :) – Khalil Khalaf Apr 06 '16 at 23:37

Thomas Matthews · Answer 2 · 2016-04-06T23:31:16.793

0

Your poor little burrito is confused. Confused burritos can't help much.

You may want your burrito declaration as:

class Burrito
{
public:
    Burrito();
    void set_name(const std::string& new_name);
    std::string get_name() const;
private:
    std::string name;
};

The methods could be defined in the source file as:

void
Burrito::set_name(const std::string& new_name)
{
  name = new_name;
}

std::string
Burrito::get_name() const
{
  return name;
}

edited Apr 06 '16 at 23:31

answered Apr 06 '16 at 23:25

Thomas Matthews

56,849
17
98
154

this is too much for a beginner. – Khalil Khalaf Apr 06 '16 at 23:28
`set_name` needs a `void` return type in header file :) – sjrowlinson Apr 06 '16 at 23:28
Since I'm new to c++ I have no idea what alot of the things u did mean so I'll have to look it up, Thanks for the help! – Ammar T. Apr 06 '16 at 23:29
@ArchbishopOfBanterbury: Thanks for identifying a defect. :-). Corrected. – Thomas Matthews Apr 06 '16 at 23:31
2

@FirstStep: How is this too much for a beginner? I took the OP's code and organized it correctly. – Thomas Matthews Apr 06 '16 at 23:33
What if he doesn't know what is to pass by reference? or why we use const with the parameter or inline? – Khalil Khalaf Apr 06 '16 at 23:37
1

@FirstStep I have no idea what either of those are, thats why I went with yours since it didn't add anything I didn't know. – Ammar T. Apr 06 '16 at 23:39
1

@FirstStep: Then he has a poor education. I recommend that references be taught before function creation. – Thomas Matthews Apr 06 '16 at 23:39
@thomasmatthews Maybe you are right and I should go with your advice. – Khalil Khalaf Apr 07 '16 at 00:00

nivbala · Answer 3 · 2016-04-06T23:33:38.643

0

The header file only has a constructor for the class. The member functions

   setName(string) and getName()

are not declared in the header file and that is why you get the error. Also, you need to specify the return type for functions.

One way to do this would be

 //Header 
 //burrito.h   
class burrito{
   private:
   string burrito_name; 
   public:
       burrito();
       string getName(); 
       void setName(string);
             }

//burrito.cpp
#include "burrito.h"
#include <iostream>

using namespace std;

string burrito::getName()
{
return burrito_name; 
}

void burrito::setName(string bname)
{
 bname =burrito_name;
}

edited Apr 06 '16 at 23:33

answered Apr 06 '16 at 23:30

nivbala

3
1
6

the member function setName() needs a string as a parameter :) – Khalil Khalaf Apr 06 '16 at 23:31
@FirstStep Were you pointing to the setName() on the first line? I just edited it – nivbala Apr 06 '16 at 23:36

score 0 · Answer 4 · 2016-08-09T11:10:31.023

This is a simple example for class in C++,
Save this in burrito.cpp file then compile and run it:

#include <iostream> 
#include <string> 
using namespace std;
class burrito {
public:
    void setName(string s);
    string getName();
private:
    string name;
};

void burrito::setName(string s) {
    name = s;
}
string burrito::getName() {
    return name;
}

int main() {
    burrito a;
    a.setName("Ammar T.");
    std::cout << a.getName() << "\n";
    return 0;
}

No variable member function declared in class?

can sombody explain to me why my code will not work, and how to fix it thanks :)

4 Answers4