0

I am a newcomer to Android Programming and hope someone can help. I am trying to populate a spinner with a column name league_name from a Database table Leagues and have come across the following error trying to do so:

Process: com.example.android.soccerleaguesapp, PID: 11770
   java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.android.soccerleaguesapp/com.example.android.soccerleaguesapp.add_team}: java.lang.NullPointerException
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2195)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245)
       at android.app.ActivityThread.access$800(ActivityThread.java:135)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:136)
       at android.app.ActivityThread.main(ActivityThread.java:5021)
       at java.lang.reflect.Method.invokeNative(Native Method)
       at java.lang.reflect.Method.invoke(Method.java:515)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:827)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:643)
       at dalvik.system.NativeStart.main(Native Method)
    Caused by: java.lang.NullPointerException
       at com.example.android.soccerleaguesapp.add_team.onCreate(add_team.java:55)
       at android.app.Activity.performCreate(Activity.java:5231)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1090)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2159)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245) 
       at android.app.ActivityThread.access$800(ActivityThread.java:135) 
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196) 
       at android.os.Handler.dispatchMessage(Handler.java:102) 
       at android.os.Looper.loop(Looper.java:136) 
       at android.app.ActivityThread.main(ActivityThread.java:5021) 
       at java.lang.reflect.Method.invokeNative(Native Method) 
       at java.lang.reflect.Method.invoke(Method.java:515) 
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:827) 
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:643) 
       at dalvik.system.NativeStart.main(Native Method) 

add_team class

public class add_team extends AppCompatActivity {

 //Calls DatabaseHelper Class
 DatabaseHelper myDb;

 //Create EditText Variable to cast in OnCreate method
 EditText team_name;

 //Create Button Variables to cast in OnCreate method
 Button add_team, get_teams;

 //Create Spinner Variables to cast in OnCreate method
 Spinner league;

 ArrayList < String > leagues = new ArrayList < String > ();

 ArrayAdapter < String > adapter;

 @Override
 protected void onCreate(Bundle savedInstanceState) {
  super.onCreate(savedInstanceState);
  setContentView(R.layout.add_team);

  myDb = new DatabaseHelper(this);

  team_name = (EditText) findViewById(R.id.edit_team_name);

  add_team = (Button) findViewById(R.id.insert_team);
  get_teams = (Button) findViewById(R.id.view_teams);

  league = (Spinner) findViewById(R.id.edit_league_id);

  adapter = new ArrayAdapter < String > (this, android.R.layout.simple_list_item_1, leagues);

  add_team.setOnClickListener(new View.OnClickListener() {
   @Override
   public void onClick(View v) {

    leagues.clear();

    Cursor cursor = myDb.getAllLeagues();

    while (cursor.moveToNext()) {
     //Extract the data
     String leagueName = cursor.getString(1);

     leagues.add(leagueName);
    }
    league.setAdapter(adapter);

   }
  });

 }

}

getAllLeagues method

public Cursor getAllLeagues() {
 //Create SQLiteDatabase instance
 SQLiteDatabase db = this.getReadableDatabase();

 String[] columns = {
  ID,
  LEAGUE_NAME
 };

 //Return query to return cursor object
 return db.query(LEAGUES_TABLE, columns, null, null, null, null, null);
}

Any help would be greatly appreciated.

mcclosa
  • 943
  • 7
  • 29
  • 59
  • 1
    post `add_team.xml` file here to we give perfect solution. –  Apr 09 '16 at 04:45
  • @Clara I hadn't thought about that and realised that I had given referenced the incorrect id, should have been `insert_teams` instead of `insert_team`, thanks for pointing me in the right direction. – mcclosa Apr 09 '16 at 04:52
  • @mcclosa now you have solve it or not ? –  Apr 09 '16 at 04:53

1 Answers1

0

Replace your code with following on On Button Click 

                if (leagues == null) {
                    leagues = new ArrayList<String>();
                }
                leagues.clear();
                Cursor cursor = myDb.getAllLeagues();
                if (cursor != null) {
                    while (cursor.moveToNext()) {
                        //Extract the data
                        String leagueName = cursor.getString(1);

                        leagues.add(leagueName);
                    }
                    league.setAdapter(adapter);
                }
Dhaval Solanki
  • 4,589
  • 1
  • 23
  • 39