Unexpected && T_BOOLEAN_AND with username and password form - PHP

Question

So I've got a very simple html page which uses a post php method to send the username and password to the php script. However I get the error: unexpected '&&' (T_BOOLEAN_AND) when the details are passed to the script. Any ideas why?

Here's the html form:

<form action="login.php" method="post">
    <p> Username: </p>
    <input type="text" name="username"/>
    <p> Password: </p>
    <input type="text" name="password"/>
    <input type="submit" value="Submit"/>
</form>

And here is the login.php script:

 <?php
    if ($_POST["username"] == "t5" ) &&
        ($_POST["password"] == "just4fun") {    
        session_start();
        $_SESSION[‘username’] = true;
        header('Location  menu.php');
    }
    else { header('Location loginform.html') }
?>

Thanks in advance.

`[‘username’]` curly quotes. *Beautiful, yet deadly*. and these will fail you `Location (file)`. RTM on that. — Funk Forty Niner, Apr 11 '16 at 17:56
Dear you have forgotten to close bracket in your if condition. — Arjun J Gowda, Apr 11 '16 at 18:00

Andrew Rayner · Accepted Answer · 2016-04-11T18:05:29.443

2

This should work, also notice how I changed the == to ===. This is good practive when checking a string.

You were missing a ; after the else statement and the && needs to go inside of the if(condition && condition)

if ($_POST["username"] === "t5" && $_POST["password"] === "just4fun") 
    {    
         session_start();
         $_SESSION['username'] = true;
         header('Location: menu.php');
    } else {
         header('Location: loginform.html');
    }

edited Apr 11 '16 at 18:05

answered Apr 11 '16 at 18:01

Andrew Rayner

1,056
1
6
20

aren't you even going to point "where" they failed? – Funk Forty Niner Apr 11 '16 at 18:01
not my dv here, should you ask yourself – Funk Forty Niner Apr 11 '16 at 18:04
Identifier? When did `==` and `===` become identifiers? And why would you change them? What difference would it make here? – Jay Blanchard Apr 11 '16 at 18:04

Wowsk · Answer 2 · 2016-04-11T18:01:56.617

0

The && sign for your if statement goes inside the parentheses and there should only be one set of parentheses.

if ($_POST["username"] == "t5" && $_POST["password"] == "just4fun")

Also [‘username’] should have quotes ['username']

Location should be followed with colons too.

edited Apr 11 '16 at 18:01

answered Apr 11 '16 at 17:56

Wowsk

3,637
2
18
29

you missed a few things – Funk Forty Niner Apr 11 '16 at 17:58
Wait what did I miss? – Wowsk Apr 11 '16 at 17:59
look over their code again, real careful like. You already added one from your original post/edited. – Funk Forty Niner Apr 11 '16 at 17:59
I caught the colons. Is there still more? – Wowsk Apr 11 '16 at 18:02
pretty much covers it. Yet, adding an `exit;`after each header wouldn't hurt. – Funk Forty Niner Apr 11 '16 at 18:05
You *could* have more than one set of parentheses, i.e `((this test) && (that test) && (the other test))`. Four sets, no waiting! – Jay Blanchard Apr 11 '16 at 18:06

Unexpected && T_BOOLEAN_AND with username and password form - PHP

2 Answers2