ImageView on again click

Question

I want my ImageView to change it's drawable resource as it is pressed. The problem occurs when ImageView is pressed for the second time.

Let me explain, if ImageView is pressed first time, I want it to change from drawable A to drawable B. If ImageView is pressed again I want it to change from drawable B to drawable A.

That pressed again part is not working..

Here's my code:

public void imageViewBiljeskeNaListiCheckMarkMetoda(View view){
        imageViewBiljeskeNaListiCheckMark = (ImageView) findViewById(R.id.imageViewBiljeskeNaListiCheckMark);
        if (view == imageViewBiljeskeNaListiCheckMark){
            imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_obavljeno);
        } else {
            imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_nije_obavljeno);
        } 
    }

You can make checkbox do that. http://stackoverflow.com/questions/7783787/how-to-change-default-images-of-checkbox — Gabe Sechan, Apr 14 '16 at 20:42

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2016-04-14T21:04:07.077

2

Remove this from the method.... You need to init the object once in the onCreate...

imageViewBiljeskeNaListiCheckMark = (ImageView) findViewById(R.id.imageViewBiljeskeNaListiCheckMark);

Then add a boolean variable to control the state of the view. .

public void imageViewBiljeskeNaListiCheckMarkMetoda(View view){
        flag =!flag;

        if (view == imageViewBiljeskeNaListiCheckMark){
          if (flag) {imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_obavljeno);
        } else {
            imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_nije_obavljeno);
        } 
}

edited Apr 14 '16 at 21:04

answered Apr 14 '16 at 20:50

ΦXocę 웃 Пepeúpa ツ

47,427
17
69
97

What exactly is that flag? – DaxHR Apr 14 '16 at 20:51
1

A boolean value to control the state of the view – ΦXocę 웃 Пepeúpa ツ Apr 14 '16 at 20:52
Declare it as a variable in the activity... boolean flag; – ΦXocę 웃 Пepeúpa ツ Apr 14 '16 at 20:53
Yeah but flag !=flag is still not a statement – DaxHR Apr 14 '16 at 20:54

score 1 · Answer 2 · answered Apr 14 '16 at 20:45

1

I sugggest to use the "tag" of the view, and keep in the tag the information you need (e.g. if the view is pressed or not)

http://developer.android.com/intl/es/reference/android/view/View.html#setTag(java.lang.Object)

answered Apr 14 '16 at 20:45

Matias Elorriaga

8,880
5
40
58

score 1 · Answer 3 · answered Apr 14 '16 at 20:53

Can't you just use a toggle method like this?

private void toggleDrawableOnClick(){

    /* now you can check to see if the set drawable is A using its id */
    if(visible drawable is A){
      imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_nije_obavljeno);
    }else{
      imageViewBiljeskeNaListiCheckMark.setImageResource(R.drawable.ic_biljeske_obavljeno);
    }
}

This should be easier I believe!!

ImageView on again click

Here's my code:

3 Answers3