List of items has same index

Asked Apr 15 '16 at 17:28

Active Apr 15 '16 at 18:30

Viewed 22 times

The following code is part of a dropdown with all the months of the year, where Constants.MONTHS is a list of all months.

var months = Constants.MONTHS;
for(var i = 0 ; i < months.length ; i++) {
  items.push(<li onClick={()=>this.chooseMonth(i)}><a href="#">{months[i]}</a></li>);
}
return items;

My issues is that whichever item in the dropdown list is clicked, the method this.chooseMonth is called with parameter 12.

So it looks like this.chooseMonth(i) only gets the value of i from the last iteration.

How can I make every item in the dropdown call this.chooseMonth with a distinct index?

edited Apr 15 '16 at 18:30

Hugo S. Mendes

1,076
11
23

asked Apr 15 '16 at 17:28

bsky

19,326
49
155
270

1

Either the dupe, or use ES2015 `let` instead. – Dave Newton Apr 15 '16 at 17:31
This isn't valid syntax, if it was a properly formatted string wouldn't this work without worrying about closures? – IrkenInvader Apr 15 '16 at 17:34
It looks like React, not vanilla JS (would be good to mention in a post when React syntax is used.) – JJJ Apr 15 '16 at 17:36
Oh alright, my bad – IrkenInvader Apr 15 '16 at 17:37

List of items has same index

0 Answers0