Recursion between different objects and combine them uniquely, without duplicate

Question

I've been trying to figure out how to do recursion for 2 objects that have similar properties, but also have differences. I need to merge these 2 objects in a unique way, so there are no duplicate countries or models etc.

EDIT: in vanilla js only please

var us1 = {
  country: {
    "United States": {
      "Ford": {
        "engine": {
          type1: "4 cyl",
          type2: "6 cyl"
        }
      },
      "Chevy": {
        "engine": {
          type1: "6 cyl"
        }
      }
    }
  }
}

var us2 = {
  country: {
    "United States": {
      "Ford": {
        "engine": {
          type3: "12 cyl"
        }
      },
      "Saturn": {
        "engine": {
          type1: "4 cyl"
        }
      }
    }
  }
}

var cars = [us1, us2];
var newCars = [];

function fn(cars) {
  if (typeof cars == "object") {
    for (var attr in cars) {
      if (!newCars.hasOwnProperty(cars[attr])) {
        newCars.push(cars[attr]);
      }

      fn(cars[attr])
    }
  } else {
    //
  }
}

console.log(fn(cars));
console.log(newCars)

Result wanted: var us1 = { country: { "United States": { "Ford": { "engine": { type1: "4 cyl", type2: "6 cyl", type2: "12 cyl" } }, "Chevy": { "engine": { type1: "6 cyl" } }, "Saturn": { "engine": { type1: "4 cyl" } } } } }

I was thinking get every property and keep iterating til its over — Tatarin, Apr 21 '16 at 00:26
No I dont, I guess I thought it was the only concept to this problem — Tatarin, Apr 21 '16 at 00:52
Can you show your result in actual Javascript or JSON form so we know exactly what you want? — jfriend00, Apr 21 '16 at 00:55
Check out this answer. http://stackoverflow.com/a/383245/5651 — jessegavin, Apr 21 '16 at 00:58
@jessegavin I think it is what i'm looking for, ill test it out — Tatarin, Apr 21 '16 at 01:39

score 1 · Accepted Answer · answered Apr 21 '16 at 01:12

If you don't want to use a library, it's trivial to write yourself. Something along the lines of

// (to: Object, ...sources: Object[]) => Object
function mergeDeep(to) {
  const sources = Array.from(arguments).slice(1)

  // (to: Object, from: Object) => void
  const _merge = (to, from) => {
    for (let a in from) {
      if (a in to) {
        _merge(to[a], from[a])
      } else {
        to[a] = from[a]
      }
    }
  }

  sources.forEach(from => {
    _merge(to, from)
  })

  return to
}

See demo here https://tonicdev.com/bcherny/mergedeep

But really, you should be using a library for this. Writing it yourself is guaranteed to be buggier and slower than any widely used existing implementation.

@jfriend00 I'm not sure we're looking at the same code.. OP doesn't seem to have `4 6 cyl` anywhere. — bcherny, Apr 21 '16 at 01:15

score 0 · Answer 2 · answered Apr 21 '16 at 00:21

0

Using lodash:

_.merge(us1, us2)

answered Apr 21 '16 at 00:21

bcherny

3,072
2
27
35

is there a way to do it only in vanilla JS? – Tatarin Apr 21 '16 at 00:25
technically this works in lodash, but i dont want to add lodash just for this functionality, ill still +1 for working answer – Tatarin Apr 21 '16 at 00:36
@jfriend00 it was fault on my behalf I comma separated them, I also updated the question right away. Sorry about that, didnt mean to confuse you guys. I still need that obj to be deep merged together, but only in vanilla js. I appreciate you looking into this issue, hoping I can still get an answer. – Tatarin Apr 21 '16 at 00:50

score -2 · Answer 3 · answered Apr 21 '16 at 00:20

-2

If you are open to use underscore.js, the following should work:

_.extend(us1, us2)

answered Apr 21 '16 at 00:20

ryan

974
2
7
13

Does this really turn individual properties into an array to merge their contents? Somehow I doubt it. – jfriend00 Apr 21 '16 at 00:22
1

`_.extend` does a shallow merge - OP is asking for a deep merge. – bcherny Apr 21 '16 at 00:22
Wasn't aware the OP is asking for a deep merge specifically. The above answer gives what OP wanted literally. – ryan Apr 21 '16 at 02:17

Recursion between different objects and combine them uniquely, without duplicate

3 Answers3