can't draw tkinter image in function

Question

i'm making a monopoly game, & i am trying to draw image on canvas, but it will only work if not in function:

def make_image(root, location, canvas):
photo = PhotoImage(file = root)
canvas.create_image(location["X"],location["Y"], image = photo, anchor = "nw")

class something():
def start(self, controller):
    self.controller = controller
    #photo = PhotoImage(file = "googolopoly.png")
    #self.canvas.create_image(0,0, image = photo, anchor = "nw")
    make_image("googolopoly.png", {"X":0,"Y":0}, self.canvas)
    make_text(self.canvas, "MONOPOLY!!!!", {"X":1050,"Y":20})
    make_button(self.main_tk, self.canvas, "roll dice", lambda: self.roll_dice(), {"X":1100, "Y":50}, 100)
    for i in range(controller.player_number):
        self.players.append(make_text(self.canvas, str(i+1), {"X":902+i*10, "Y":946}))
    self.main_tk.mainloop()

currently it won't draw a picture, but if i get down the comments it will work (no function) it also happens after main loop, when i want to draw players

i really need it as a function. what to do? if you need i can put some more code

you sure you want it on canvas? it would be easier to do on a Label — Liam, May 13 '16 at 15:37
Actually I don't know what a lable is. What I wrote is what we were taught at class. If you say there is an easier solution please add an answer. (But I am using canvas for everything else) — Alon Kagan, May 13 '16 at 15:55
Can you please post another question on how to do that with Labels? A label is a text element on the window by the way — Liam, May 13 '16 at 15:57
What does "not work" mean? Does your program crash? Does it create the wrong image? does it create a blank image? Have you researched this? There are many questions and answers along the lines of "why doesn't my image show up when created in a function?". — Bryan Oakley, May 13 '16 at 16:10
the image is just not shown but the program will continue to work fine @BryanOakley — Liam, May 13 '16 at 16:15

score 3 · Answer 1 · answered May 13 '16 at 15:42

3

You were missing this line of code: myCanvas.image = photo.

And even if it would be easier to draw the image on a Label, with this code you can do it on a Canvas with the function make_image():

from Tkinter import *


def make_image(filename, location, canvas):
    photo  = PhotoImage(file=filename)
    myCanvas.image = photo
    myCanvas.create_image(0,0, image = photo, anchor = "nw")



root = Tk()

myCanvas = Canvas(root, width=100, height=100)
myCanvas.grid()


make_image("image.gif", (5,5,95,95), myCanvas)

root.mainloop()

answered May 13 '16 at 15:42

Liam

6,009
4
39
53

But you say you want to create a variable named photo in the class mycanvas? So it will remake the variable every time I make the photo won't it? – Alon Kagan May 13 '16 at 15:53
something like that @AlonKagan – Liam May 13 '16 at 15:56
does it work @AlonKagan? – Liam May 13 '16 at 16:32
Actually I am not home, but if I call the function a second time won't it delete last picture? – Alon Kagan May 13 '16 at 17:09
It will not @AlonKagan – Liam May 13 '16 at 17:12
OK, thanks I will update in an hour – Alon Kagan May 13 '16 at 17:27
it did delete them, but i made canvas.photos an array of all photos, and now it works. thanks – Alon Kagan May 13 '16 at 21:28
but can i do it without taking so much memory? – Alon Kagan May 13 '16 at 21:54
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/111912/discussion-between-liam-and-alon-kagan). – Liam May 14 '16 at 07:21

can't draw tkinter image in function

1 Answers1