Js if/else statement not working

Question

I'm trying to get the width and height of certain images equal (or, more specific: the div around it), but somehow it doesn't seem to work.. Anyone who can help?

$('.a2paragraph .image img').each(function() {
    var img = $('.a2paragraph .image img');

    var h = img.height(),
        w = img.width();

    if (h > w) {
        img.parent().css('height', w);
    }
    else if (w < h) {
        img.parent().css('width', h);
    }


});

EDIT: changed the code, but still not working:

$('.a2paragraph .image img').each(function() {
    var img2 = $('.a2paragraph .image img');

    var h = img2.height(),
        w = img2.width();

    if (h > w) {
        img2.parent().css('height', w);
    }
    else if (h < w) {
        img2.parent().css('width', h);
    }


})

So you have an image with an id "img"? I doubt that is what you want. DOM does not have height() and width(). You are mixing up jQuery and DOM. — epascarello, May 31 '16 at 14:07
Yeah it was just to test it, but that isn't the error though. — Esmeralda van Daalen, May 31 '16 at 14:08
Possible duplicate of [How can I debug my JavaScript code?](http://stackoverflow.com/questions/988363/how-can-i-debug-my-javascript-code) — Liam, May 31 '16 at 14:09

Victor Sand · Answer 1 · 2016-05-31T14:10:36.697

5

if (h > w) {
    img.parent().css('height', w);
}
else if (w < h) {
    img.parent().css('width', h);
}

The if and the else if conditions are the same. You're checking for h > w twice, just written in different orders.

edited May 31 '16 at 14:10

answered May 31 '16 at 14:08

Victor Sand

2,270
1
14
32

1

plus it misses the case where `h=w` – Marc B May 31 '16 at 14:09
@MarcB Does not matter since setting the opposite to equal the other is the same thing... – epascarello May 31 '16 at 14:10
Oh!! Haha wow that's stupid.. Thanks a lot. No it doesn't have to do anything when they're equal :) – Esmeralda van Daalen May 31 '16 at 14:10
`img` contains all images and therefor returns always the height and width of the first image. Change it to `var img = $(this)` instead – Andreas May 31 '16 at 14:15
@Andreas ah okay, thanks! Changed it but doesn't solve it though.. it just doesn't add the css to img.parent() ? – Esmeralda van Daalen May 31 '16 at 14:18

Js if/else statement not working

1 Answers1