pushing multiple arrays into one is forming a 2 dimensional array

Question

Following code is returning the length of allRows[] as 3, because it has 3 arrays in it. I am trying to build one final array allRows.

  getRows() {
    return this.element.all(by.css(".xyz")).getText();
  }

  getTotalRows() {
    const allRows = [];

    for (let i = 0; i < 3; i++) {
      allRows.push(this.getRows());
      this.scrollDown();
      this.waitToLoad();
    }
    return allRows;
  }

Actually getRows() is returning an array of promises. Following changes to my code has fixed the issue

  getRows() {
    return this.pinnedRows.getText();
  }

  getTotalRows() {
    const defer = Promise.defer();
    let allRows = [];

    for (let i = 0; i < 3; i++) {
      this.getRows().then((rows) => {
        allRows = allRows.concat(rows);
        this.scrollDown();
        this.waitToLoad();
        if (i === 2) {
          defer.resolve(allRows);
        }
      });
    }
    return defer.promise;
  }

Possible duplicate of [How to merge two arrays in Javascript and de-duplicate items](http://stackoverflow.com/questions/1584370/how-to-merge-two-arrays-in-javascript-and-de-duplicate-items) — kamal pal, Jun 01 '16 at 16:59

score 2 · Accepted Answer · answered Jun 01 '16 at 16:58

2

Pushing adds one index, what you want is concat()

answered Jun 01 '16 at 16:58

epascarello

204,599
20
195
236

I tried concat but it was returning empty array. Let me try again and see if I am doing it wrong way. – kvm006 Jun 01 '16 at 17:21
allRows = allRows.concat(this.getRows()); – epascarello Jun 01 '16 at 17:24
just tried this ... even this is returning array of arrays :( – kvm006 Jun 01 '16 at 18:11

pushing multiple arrays into one is forming a 2 dimensional array

1 Answers1