How to make a program like this anymore domino

Question

if I input kampret, how to declarate it into a variable, examples ALEX is a name variable , 19 is old variable , and INDIA is country variable. with my program

#include <iostream>
#include <cstring>
using namespace std;

int main(){
char str[100];
cout<<"Enter string : ";cin>>str;
char *point;
point=strjum(str, "#");

while(point!=NULL){
    cout<<point<<endl;
    point = surtok(NULL, "#");
}
}

What is "variable"? Names of variables declared in C++ code won't be available except for in debugging information. — MikeCAT, Jun 01 '16 at 17:12
You can refer to [this answer](http://stackoverflow.com/a/236803/962089) to split a string. A `std::string` will certainly be safer than your current, easy-to-attack input method. Once you split the string, accessing the pieces to store them in separate variables is much easier. — chris, Jun 01 '16 at 17:14
More info why not to use `strtok()` [here](http://stackoverflow.com/questions/2799023/what-exactly-is-a-reentrant-function/2799288#2799288). — πάντα ῥεῖ, Jun 01 '16 at 17:15

pm100 · Accepted Answer · 2016-06-01T18:09:09.670

0

you should really use std:string and its methods, but if you must use strtok:

char *name;
char * age;
char * country;
point=strtok(str, "#");
if(point != NULL)
{
  name = strdup(point);
  point = strtok(NULL, "#");
  if(point != NULL)
  {
    age = strdup(point);
    point = strtok(NULL, "#");
    if(point != NULL)
    {
      country = strdup(point);
    }
  }
}

edited Jun 01 '16 at 18:09

answered Jun 01 '16 at 17:19

pm100

48,078
23
82
145

some error zack.cpp:23:34: error: invalid conversion from ‘char*’ to ‘char’ [-fpermissive] char country = strdup(point); – Kurnia Rocki Jun 01 '16 at 17:30
it should be just `country` so, `country = strdup(point);` @KurniaRocki – Soner from The Ottoman Empire Jun 01 '16 at 17:38
you should `free` after `strdup` usage which is inconvenient. AFAIK, it uses `malloc`. This is another reason why `std::string` is better in C++ – Soner from The Ottoman Empire Jun 01 '16 at 17:40
@snr - yup, i assumed that the OP could do `man strdup`. Plus the 3 vars should be inited to NULL – pm100 Jun 01 '16 at 18:09

Soner from The Ottoman Empire · Answer 2 · 2016-06-01T17:48:01.657

std::string is more safer than your method like chris mentioned as a comment. For your learning:

#include <iostream>
#include <string>

int main() {
    std::string s = "ALEX#19#INDIA";
    std::string delimiter = "#";

    size_t pos = 0;
    std::string token;
    while ((pos = s.find(delimiter)) != std::string::npos) {
        token = s.substr(0, pos);
        std::cout << token << std::endl;
        s.erase(0, pos + delimiter.length());
    }
    std::cout << s << std::endl;
    return 0;
}

What I do if I need like the code

#include <string>
#include <vector>
#include <functional>
#include <iostream>

void split(const std::string& s, char c,
           std::vector<std::string>& v) {
    std::string::size_type i = 0;
    std::string::size_type j = s.find(c);

    while (j != std::string::npos) {
        v.push_back(s.substr(i, j-i));
        i = ++j;
        j = s.find(c, j);

        if (j == std::string::npos)
            v.push_back(s.substr(i, s.length()));
    }
}

int main() {
    std::vector<std::string> v;
    std::string s = "ALEX#19#INDIA";
    char delimiter = '#';

    split(s, delimiter, v);

    for (auto& i : v) {
        std::cout << i << '\n';
    }
}

How to make a program like this anymore domino

2 Answers2