BufferedReader not reading entire text file

Question

                String str = "";
            try {

                BufferedReader br = new BufferedReader(new FileReader(file.getAbsolutePath()));
                while (br.readLine() != null) {
                    str += br.readLine();
                }
            } catch (Exception e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }

            String replace = str.replace("HTTP Request: ", "")
                    .replace("Resource URL: ","")
                    .replace("Attribute\t\tDescription", "| Attribute | Type | Description |<P>|----|----|<P>")
                    .replace("Data Type | Max Length | Requirement |", "")
                    .replace("N/A", "Object")
                    .replace("String", "| String")
                    .replace("255 |", "")
                    .replace("Required", "**Required**")
                    .replace("Optional", "**Optional**")
                    .replace("Request Example <P>", "")
                    .replace("Response Example <P>", "Nothing");

            PrintWriter pw = null;

The BufferedReader ignores the first 3 lines and reads/converts the rest. Not sure as to what the issue is. I have tried other StackOverflow solutions but none of them seem to work!

yes, I sysout'd str and it prints without the first 3 lines. — Suhail Prasathong, Jun 14 '16 at 20:13

score 7 · Accepted Answer · answered Jun 14 '16 at 20:16

7

The problem is here:

while (br.readLine() != null)

The time that you check if the br.readLine() is not null you have already read the line.To fix this you can try the following:

String line = br.readLine();
while (line != null){
    str +=line;
    line = br.readLine();
}

answered Jun 14 '16 at 20:16

theVoid

743
4
14

@Suhail Prasathong I am glad I helped,but remember to accept a solution to close the question,it does't have to be mine. – theVoid Jun 15 '16 at 05:08

score 2 · Answer 2 · answered Jun 14 '16 at 20:44

You only check the return value of br.readLine() while you are supposed to treat it as well, here is the common code:

StringBuider buffer = new StringBuilder();
try (BufferedReader br = new BufferedReader(new FileReader(file.getAbsolutePath()))) {
    String line;
    while((line = br.readLine()) != null) {
        buffer.append(line);
    }
}

Himanshu Shankar · Answer 3 · 2016-06-14T20:34:47.633

0

theVoid already told what problem is a gave a solution.

In the cases where cinditional statement are iterative functions, I always prefer to use

do{
    //task
    //Iterate and store result in var, like in your case
    var = br.readLine();
}while(var != null/*check on var rather than executing iteration*/);

edited Jun 14 '16 at 20:34

answered Jun 14 '16 at 20:27

Himanshu Shankar

735
1
6
24

BufferedReader not reading entire text file

3 Answers3