How to implement search function in django?

Question

I have many books in a database. Searching the database returns nothing(empty queryset).

In the menu:

<form name="myform" method="POST" action="{% url 'search' %}">  
    {% csrf_token %}
    <input type="text" name="search" placeholder="Search" />
</form>

views.py,

def search(request):        
    if request.method == 'POST':      
        book_name =  request.POST.getlist('search')      
        try:
            status = Add_prod.objects.filter(bookname__icontains=book_name)
            #Add_prod class contains a column called 'bookname'
        except Add_prod.DoesNotExist:
            status = None
        return render(request,"search.html",{"books":status})
    else:
        return render(request,"search.html",{})

My template file,

{% if books %}
    <a href="{% url 'buy_book' pk=books.pk %}">
    <!--Upon successful search book image with hyperlink appears -->
    <img src="{{books.image.url}}" alt="No Image"></a>
    <p>{{books.bookname}}</p>
    <p>Rs.{{books.price}}</p>   
{% endif %}

Good for some use cases, but you should also take a look at document based search as your need evolves. https://docs.djangoproject.com/en/dev/topics/db/search/#document-based-search — keni, Jun 24 '16 at 10:22

score 13 · Accepted Answer · edited May 23 '17 at 10:29

There are couple of things I would like to add here..

1) I think search result should be of method GET not POST. You might refer this link to see when to use POST and when to use GET

<form name="myform" method="GET" action="{% url 'search' %}"> 
// see if you need csrf_token here when this is GET request. Your homework

2) views.py

def search(request):        
    if request.method == 'GET': # this will be GET now      
        book_name =  request.GET.get('search') # do some research what it does       
        try:
            status = Add_prod.objects.filter(bookname__icontains=book_name) # filter returns a list so you might consider skip except part
        return render(request,"search.html",{"books":status})
    else:
        return render(request,"search.html",{})

3) django template should be now

{% if books %}
{% for each_book in books %} // books is list here so pick each element using for loop 
    <a href="{% url 'buy_book' pk=each_book.pk %}">
    <!--Upon successful search book image with hyperlink appears -->
    <img src="{{each_book.image.url}}" alt="No Image"></a>
    <p>{{each_book.bookname}}</p>
    <p>Rs.{{each_book.price}}</p>   
{% endfor %}
{% endif %}

This should be working fine.

Also make you sure you have some data in db to fetch you some result on search!

can you share your urls.py file ? I think you have messed up there — d-coder, Jun 24 '16 at 06:04
request.POST.get() didn't work so I changed it to request.GET.get() now its working — Kiran, Jun 24 '16 at 06:07
BTW did you understand why you should use request.GET.get() ? — d-coder, Jun 24 '16 at 06:09

score 3 · Answer 2 · answered Jul 10 '20 at 13:46

Your form in the main HTML from where you will use the search option should something like this:-

<form name="myform" method="GET" action="{% url 'search' %}">  
<input type="text" name="search" placeholder="Search" /></form>

You need to edit your views.py as

def search(request):
    if request.GET.get('myform'): # write your form name here      
        book_name =  request.GET.get('myform')      
        try:
            status = Add_prod.objects.filter(bookname__icontains=book_name)
            return render(request,"search.html",{"books":status})
        except:
            return render(request,"search.html",{'books':status})
   else:
        return render(request, 'search.html', {'books':status})

And your Django template should look like this:-

   {% if books %}
       {% for each_book in books %} 
           <a href="{% url 'buy_book' pk=each_book.pk %}">
           <img src="{{each_book.image.url}}" alt="No Image"></a>
           <p>{{each_book.bookname}}</p>
           <p>Rs.{{each_book.price}}</p>   
       {% endfor %}
   {% endif %}

By doing this your code work perfectly fine by then...

Martín Muñoz del Río · Answer 3 · 2016-06-24T05:44:16.963

1

Looks like you need to use a for, because books is a queryset

In template, try:

{% if books %}
{% for book in books %}
    <a href="{% url 'buy_book' pk=book.pk %}">
    <!--Upon successful search book image with hyperlink appears -->
    <img src="{{book.image.url}}" alt="No Image"></a>
    <p>{{book.bookname}}</p>
    <p>Rs.{{book.price}}</p>   
{% endfor %}
{% endif %}

And in your views:

Instead:

book_name =  request.POST.getlist('search')

try:

book_name =  request.POST.get('search')

edited Jun 24 '16 at 05:44

answered Jun 24 '16 at 05:33

Martín Muñoz del Río

1,958
11
14

@Bhanukiran can you show your models, maybe you need to use book.id instead book.pk – Martín Muñoz del Río Jun 24 '16 at 06:03

How to implement search function in django?

3 Answers3