Is there a better way of creating an "abstract" linear search?

Question

so I'm trying to write a linear search which could be used for most non-primitive data types.

Here is the code I'm using:

public static <T> boolean search(Comparable<T> key, T[] array) {
    for(int i = 0; i < array.length; i++) {
        if(array[i].equals(key)) {
            return true;
        }
    }
    return false;
}

I was wondering if there is a better way this could be done, or a neater way. N.B. I am just looking to use a linear search algorithm

Thanks

score 1 · Accepted Answer · answered Jul 02 '16 at 23:59

1

You could use List#contains for a linear search. Also, there's no need for Comparable in this case.

public static <T> boolean search(T needle, T[] haystack) {
    return Arrays.asList(haystack).contains(needle);
}

Note: Arrays.asList returns a List view of the array. It won't make a copy.

answered Jul 02 '16 at 23:59

4castle

32,613
11
69
106

Without using an Arrays implementation, would my answer above still be suffice? – madcrazydrumma Jul 03 '16 at 00:04
1

Yes. Though `Comparable` isn't needed. You could alternatively use a `foreach` loop too. – 4castle Jul 03 '16 at 00:05

Michael · Answer 2 · 2016-07-02T23:42:34.257

-3

Binary search works amazing! And it's quite simple.

public static <T> boolean search(Comparable<T> key, T[] array) {
    int start = 0;
    int end = array.length - 1;
    while (start <= end) {
        int mid = (start + end) / 2;
        if (key == array[mid]) {
            return true;
        }
        if (key < array[mid]) {
            end = mid - 1;
        } else {
            start = mid + 1;
        }
    }
    return false;
}

edited Jul 02 '16 at 23:42

answered Jul 02 '16 at 23:38

Michael

776
4
19

Please include relevant parts in the answer itself instead of dumping a link. Links break over time. – Ingo Bürk Jul 02 '16 at 23:41
Got it! Decided to code it up, help OP directly instead. – Michael Jul 02 '16 at 23:43
I was looking for just a linear search, not another type of search algorithm – madcrazydrumma Jul 02 '16 at 23:43

Is there a better way of creating an "abstract" linear search?

2 Answers2