Embedded statement cannot be a declaration or labeled statement

Question

I am trying to create a user using claim identity asp.net I get this error while creating claims identity user.

  ApplicationUser user = new ApplicationUser { 
                        EmailConfirmed = true, 
                        UserName = model.myUser.Email,
                        Email = model.myUser.Email ,
                        PhoneNumber = model.myUser.PhoneNumber,
                        PhoneNumberConfirmed = true,
                        UserImagePath = model.myUser.UserImagePath,
                        FirstName= model.myUser.FirstName,
                        LastName = model.myUser.LastName,
                        DateOfBirth = model.myUser.DateOfBirth,
                        Culture = model.myUser.Culture,
                        Role = model.myUser.Role
                    };

but when the code was

var user= new ApplicationUser { 

                            UserName = model.myUser.Email,
                            Email = model.myUser.Email ,

                        };

it worked perfectly, so i want to know what is wrong

I can´t see any problem here. Maybe you may remove one property after another from your statement to limit the point of failure. — MakePeaceGreatAgain, Jul 14 '16 at 12:41
" I get this error". What error? Have you tried removing the lines one at a time to find out where the problem is? — David Arno, Jul 14 '16 at 12:42
im sorry if i wasnt clear, i get Embedded statement cannot be a declaration or labeled statement, on ApplicationUser user — husseinbaalbaki, Jul 14 '16 at 12:47
I guess I know what @husseinbaalbaki means, he just didn't explain himself well. It is a C# compilation error. — felix-b, Jul 14 '16 at 12:49

score 204 · Accepted Answer · edited Dec 20 '22 at 00:40

You have a statement (if or while, for example), right before the code you posted, without curly braces.

For example:

if (somethingIsTrue) 
{    
   var user= new ApplicationUser { 
       UserName = model.myUser.Email,
       Email = model.myUser.Email ,
   };
}

is correct, but the code below:

if (somethingIsTrue) 
   var user = new ApplicationUser { 
      UserName = model.myUser.Email,
      Email = model.myUser.Email ,
   };

will result in CS1023: Embedded statement cannot be a declaration or labeled statement.

UPDATE

The reason, according to @codefrenzy, is that the newly declared variable will immediately go out of scope, unless it is enclosed in a block statement, where it can be accessed from.

The compilation will pass in the following cases though.

If you only initialize a new instance of a type, without declaring a new variable:

if (somethingIsTrue) 
   new ApplicationUser { 
       UserName = model.myUser.Email,
       Email = model.myUser.Email ,
   };

or if you assign a value to an existing variable:

ApplicationUser user;

if (somethingIsTrue) 
   user = new ApplicationUser { 
       UserName = model.myUser.Email,
       Email = model.myUser.Email ,
   };

score 9 · Answer 2 · answered Sep 29 '17 at 10:34

9

I just had this error, and the fix was to add a curly brace to the if immediately preceding my code, and then remove it again. Visual Studio facepalm OTD.

answered Sep 29 '17 at 10:34

Mel Padden

983
1
9
21

4

This answer doesn't deserve the downvotes. This error sometimes occurs when it shouln't (when no new variables are declared). When VS does something unexpected like this, a solution like this can be good fix. For us a restart of VS helped solve this issue. – Martijn Jan 15 '21 at 10:48
1

Same with me. VS can be haunted by the ghosts of old compilation errors sometimes and only a restart will fix it. – Matthew Lock Jan 25 '21 at 03:28
I just closed the file, and reopened it, didn't need to close VS. – Nick M Jan 30 '23 at 00:51

Embedded statement cannot be a declaration or labeled statement

2 Answers2

UPDATE

Linked

Related