setcookie() is not working properly

Question

I can't explain much but I am currently trying to remove a product from shopping cart which is saved in cookie.

if(isset($_GET['remove'])) {
   $remove = $_GET["remove"];
   foreach($cart_saved as $q) {
   if($q == $remove) {
       unset($cart_saved[$q]);
       setcookie("shop_items", json_encode($cart_saved), time() + 36000);
   }
}

The value is deleted from the array but I can't update the cookie

Have a look at session. You save these details there and not in raw cookies — georoot, Aug 23 '16 at 18:26
Don't call `setcookie` each time through the loop. Call it once after the loop is done. — Barmar, Aug 23 '16 at 18:33
Check your PHP error log, make sure you don't have a `Headers already sent` warning. — Barmar, Aug 23 '16 at 18:34
Does $_GET["remove"] contain a value or an index of the value to be removed? — user4035, Aug 23 '16 at 18:34
@Barmar , just checked the error log and yes i got header already sent warning, what to do? — Daniel Dimitrow, Aug 23 '16 at 18:38

score 0 · Answer 1 · answered Aug 23 '16 at 18:35

0

You write your cookie each time is why there are a problem. So :

if(isset($_GET['remove'])) {
   $remove = $_GET["remove"];
   foreach($cart_saved as $q) {
   if($q == $remove) {
       unset($cart_saved[$q]);
   }
   setcookie("shop_items", json_encode($cart_saved), time() + 36000);
}

answered Aug 23 '16 at 18:35

Gerald Chablowski

462
2
7

Tried it already , same thing. – Daniel Dimitrow Aug 23 '16 at 18:36
Have you tried to add a domain to your cookie ? – Gerald Chablowski Aug 23 '16 at 18:44
I tried, still not working – Daniel Dimitrow Aug 23 '16 at 18:47

score 0 · Accepted Answer · answered Aug 23 '16 at 18:40

0

You have an error in your loop. You need to use a key of $q as index, not the value stored in $q.
It seems reasonable to break the loop after the value is found

foreach($cart_saved as $key => $q) {
    if($q == $remove) {
        unset($cart_saved[$key]);
        setcookie("shop_items", json_encode($cart_saved), time() + 36000);
        break;
    }
}

answered Aug 23 '16 at 18:40

user4035

22,508
11
59
94

Thanks for the answer but the problem is the same – Daniel Dimitrow Aug 23 '16 at 18:46
@DanielDimitrow This fixes a part of your code. You must set cookie before any other output is made to the browser. Look at http://stackoverflow.com/questions/8028957/how-to-fix-headers-already-sent-error-in-php. – user4035 Aug 23 '16 at 18:47
Thanks i understand now. It worked like a charm! – Daniel Dimitrow Aug 23 '16 at 18:55

setcookie() is not working properly

2 Answers2