If file with name.jpg exists do A else do B

Question

I need to develop a little PHP script that I can run from a cron job which in pseudo code does the following:

//THIS IS PSEUDO CODE
If(file exists with name 'day.jpg')
    rename it to 'fixtures.jpg'
else
    copy 'master.jpg' to 'fixtures.jpg'

Where day.jpg should be the current day of the month.

I started to replace the pseudo code with the stuff I'm pretty sure how to do:

<?php

    if(FILE EXISTS WITH NAME DAY.JPG) {
        rename ("DAY.JPG", "fixtures.jpg");
    } else {
        copy ("master.jpg", "fixtures.jpg");
    }

?>

Clearly there are still a few things missing. Like I need to get the filename with the current day of the month and I need to check if the file exists or not.

I guess I need to do something like this $filename='date('j');'.jpg to get the filename, but it isn't really working so I kinda need a bit help there. Also I don't really know how to check if a file exists or not?

just piecing it all together really... gonna post an update now — Henry Aspden, Sep 08 '16 at 22:21
Can I ask why you need to rename the file and not apply the logic to the code responsible for your output? eg `on the 2nd, echo 2.jpg` — Scuzzy, Sep 08 '16 at 22:26
` if($filename = date('j') . '.jpg';) {` this is wrong you should change it to `if (date('j') . '.jpg' == $filename ) {` — Robert, Sep 08 '16 at 22:28
@HenryAspden Update 2 looks like it should work. Does it? Or where are you still stuck? — Rizier123, Sep 09 '16 at 00:17
Thanks @Rizier123 yea I fell asleep last night haha but yea works like a dream... I even tweaked it this morning to delete the day befores file... e.g on the 9th of the month delete 8.jpg... I'll post UPDATE 3 for others to look at. Guess it might help someone in the future — Henry Aspden, Sep 09 '16 at 11:21
@HenryAspden Please don't post the working code inside the question. — Rizier123, Sep 09 '16 at 11:54

score 1 · Answer 1 · answered Sep 08 '16 at 22:25

$path = __DIR__; // define path here
$fileName = sprintf("%s%d.jpg", $path, date("j"));
$fixtures = $path . DIRECTORY_SEPARATOR . "fixtures.jpg";
$master   = $path . DIRECTORY_SEPARATOR . "master.jpg";

file_exists($fileName) ? rename($fileName, $fixtures) : copy($master, $fixtures);

Basicly you need script like above but you need to work on your path. Your code above had syntax problem.

score -1 · Answer 2 · answered Sep 08 '16 at 22:21

-1

You have a basic syntax problem, it should be:

$filename = date('j') . '.jpg';

You don't put function calls inside quotes, you need quotes around the literal string '.jpg', and you need to use . to concatenate them.

I recommend you read the chapter on Strings in a PHP tutorial.

answered Sep 08 '16 at 22:21

Barmar

741,623
53
500
612

Thanks Barmar thats a big help... quick one tho, when do I use == vs just =? – Henry Aspden Sep 08 '16 at 22:22
1

@HenryAspden If you needed that, you **really** need to read a PHP tutorial from beginning to front, not just the strings chapter. – Barmar Sep 08 '16 at 22:27
I've posted an update to my code above, will somebody please take a quick look at it now. Any links to explain where and why my syntax etc is wrong would be really helpful :) As you can see I'm new to PHP. Don't really know where or how to start teaching myself the language other than project by project – Henry Aspden Sep 08 '16 at 22:27
You shouldn't put the variable assignment inside `if()`. If you want to know if the file exists, use `if(file_exists($filename))` – Barmar Sep 08 '16 at 22:28
@Barmar... PHP tutorial you say? – Henry Aspden Sep 08 '16 at 22:28
1

Yes, you clearly need to learn how to program in PHP, you don't know some of the simplest concepts. – Barmar Sep 08 '16 at 22:29
I appreciate it must be frustating to read my novice codes haha... I am trying to learn hence why I didn't just code dump and expect the answer... this time – Henry Aspden Sep 08 '16 at 22:30
1

You can't learn to program by trial and error like this, you need to get a good textbook or tutorial. Don't ask me for a recommendation, I don't know. – Barmar Sep 08 '16 at 22:33
@Barmar thanks anyway buddy... might look at some apps I can do on my phone and see if there are any good'uns... What do you think to UPDATE 2 if you don't mind me bombarding you? – Henry Aspden Sep 08 '16 at 22:35
works like a dream guys... time to start at the basics after this one – Henry Aspden Sep 08 '16 at 22:43

If file with name.jpg exists do A else do B

2 Answers2