Android OnClickListener multiple views?

Question

OnClickListener best practices?

What is best practice if you have an Activity with, let's say 10 buttons, should you create the OnClickListener for each View (Button) or is it better to create a single onClickListener and just use a switch with the view ID to determine the clicked View?

You can assign the same click event handler to multiple Views in your layout. Then in the method, check **which** is the View that fired the event. — Phantômaxx, Sep 15 '16 at 10:54

score 5 · Answer 1 · answered Sep 15 '16 at 10:54

5

@Override
public void onClick(View v) {
   switch (v.getId()) {
      case R.id.btn_1:
         //Logic_1
      break;
      case R.id.btn_2:
         //Logic_2
      break;
   }
}

answered Sep 15 '16 at 10:54

Cryperian

116
1
8

score 2 · Answer 2 · edited May 23 '17 at 11:51

If you search a little in Google or StackOverflow..

Multiple Buttons `OnClickListener()` android

Best solution is switch:

@Override
public void onClick(View v) {

    switch (v.getId()) {

        case R.id.oneButton:
            // do your code
            break;

        case R.id.twoButton:
            // do your code
            break;

        case R.id.threeButton:
            // do your code
            break;

        default:
            break;
    }

}

score 2 · Accepted Answer · answered Sep 15 '16 at 10:59

2

I know that you know code therefore i can say only:

Switch is better as a case or switch statement is considered easier to read and maintain

It is more manageable for having higher level of indentation than if.

answered Sep 15 '16 at 10:59

Androider

3,833
2
14
24

1

This was probably the only answer that was to the point, I know the code and did not ask for examples but merely in practice what is the better choice. Thanks for some actual advice! – Solx85 Sep 15 '16 at 11:07
I am happy to help you. Thanks. – Androider Sep 15 '16 at 11:08

score 1 · Answer 4 · edited May 23 '17 at 12:32

1

you can use any thing which you like to use because as computational point both are same but if you want to sort your line of code then use signal with switch case

for references see this Multiple Buttons `OnClickListener()` android

edited May 23 '17 at 12:32

Community

1
1

answered Sep 15 '16 at 10:56

shubham goyal

537
3
3

they are not the same, each new click listener is a new different inner class inside the activity – Mohammad Ersan Sep 15 '16 at 10:56
please see this http://programmers.stackexchange.com/questions/110106/what-is-the-proper-way-to-implement-the-onclicklistener-interface-for-many-butto – shubham goyal Sep 15 '16 at 11:06
`as computational point both are same` and thats wrong – Mohammad Ersan Sep 15 '16 at 11:23

Android OnClickListener multiple views?

4 Answers4