for loop not iterating through all of array

Question

I am trying to geocode an array of postcodes from a json file using gmaps.js.

There are 101 postcodes in the array however when I loop through them to use with gmaps.js it only iterates through 11. I have tried looking around for answers, however i can't figure it out, everything looks correct, here is my code

var getPostcodes = function () {
                    var json = "http://example.co.uk/addresses.json";

                    var request = new XMLHttpRequest();
                    request.open('GET', json, true);

                    request.onload = function () {
                        if (request.status >= 200 && request.status < 400) {
                            // Success!
                            var data = JSON.parse(request.responseText);

                            //GET POSTCODES IN ARRAY
                            var postcodesArray = [];
                            for (var i = 0; i < data.length; i++) {
                                postcodesArray.push(data[i].from_postcode);
                            }
                            var postcodes = postcodesArray.filter(Boolean);

                            //GET LAT/LONG POSITIONS
                            for (var n = 0; n < postcodes.length; n++) {
                                GMaps.geocode({
                                    address: postcodes[n],
                                    callback: function (results, status) {
                                        if (status == 'OK') {
                                            var location = results[0].geometry.location;

                                            var latitude = parseFloat(location.lat().toFixed(8)),
                                                longitude = parseFloat(location.lng().toFixed(8));

                                            console.log(latitude + ' ' + longitude);
                                        }
                                    }
                                });
                            }
                        }
                        else {
                            console.log("failed");
                        }
                    };
                    request.send();
                }

                getPostcodes();

//EDIT console log

//EDIT codepen link

http://codepen.io/anon/pen/gwWgzB

Did you check your console window for any errors? Once an exception occurs the script stops the execution. Probably in the last iteration it does some property is undefined and generates some kind of exception. — Glubus, Sep 26 '16 at 13:47
Is `GMaps.geocode` perhaps rate-limited, and querying it so many times in quick succession from one endpoint is not allowed? — James Thorpe, Sep 26 '16 at 13:49
the reason may be postcodes.length may be 11 ,because postcodes is string — Karthick Kumar, Sep 26 '16 at 13:50
Look at your console, I am sure there is something in the console or network tab. — epascarello, Sep 26 '16 at 13:51
I am not sure, I will try create a fiddle now for better explanation — Sai, Sep 26 '16 at 13:51
@Sai Please provide us with whatever is logged into your console, it's the most easy and obvious place to look first. — Glubus, Sep 26 '16 at 14:03
Hello i have put the code on codepen, I was having difficulties with jsfiddle — Sai, Sep 26 '16 at 14:58
Check the `status` parameter. You are getting [`OVER_QUERY_LIMIT`](https://developers.google.com/maps/documentation/javascript/geocoding#GeocodingStatusCodes). Here's a dup: http://stackoverflow.com/questions/14014074/google-maps-api-over-query-limit-per-second-limit — 001, Sep 26 '16 at 15:22
Great, thank you for the link, I will look over it to find a solution — Sai, Sep 26 '16 at 15:33

score -1 · Answer 1 · answered Sep 26 '16 at 13:53

-1

Google limits the number of geocoding requests per second. I suggest you to put sleep between consecutive requests.

answered Sep 26 '16 at 13:53

Deepak Sharma

409
4
14

`put sleep between consecutive requests` - sleep? – Jaromanda X Sep 26 '16 at 14:02
Is there a limit to how many you can geocode? for some reason it's always after 11 postcodes it stops – Sai Sep 26 '16 at 15:14
Yes. its 50 request per second and 2500 request per day. But if you don't use api key then it will stop after 11. Sleep between consecutive request means do not iterate all of the postcodes at once. – Deepak Sharma Sep 27 '16 at 05:35

for loop not iterating through all of array

1 Answers1