How to avoid duplicate file in upload using PHP?

Question

Good day everyone, I want to prevent uploading a file if the name and file extension match one of the saved records. My code below works but how can I avoid duplicate entries?

"My sample array"
Array
(
    [upload-file] => Array
        (
            [name] => Penguins.jpg
            [type] => image/jpeg
            [tmp_name] => C:\xampp\tmp\phpC87.tmp
            [error] => 0
            [size] => 777835
        )

)

case 'upload-file':

    $arr = [ 
        ":userid" => $_SESSION['loggedIn_PH'][0]['user_id'],
        ":filename" => $_FILES['upload-file']['name'],
        ":filelink" => $_FILES['upload-file']['tmp_name']
        ];

        $allowed =  array('xls','xlsx');
        $filename = $_FILES['upload-file']['name'];
        $ext = pathinfo($filename, PATHINFO_EXTENSION);

        if(!in_array($ext,$allowed) ) {
            $response_code = -1;
        }else{
            $response_code = 1;
            $folder = time();
            mkdir("path/".$folder);
            $file = "path".DIRECTORY_SEPARATOR.$folder.DIRECTORY_SEPARATOR.$_FILES['upload-file']['name'];
                    move_uploaded_file($_FILES['upload-file']['tmp_name'], $file);

        $query = "INSERT INTO file_rec_tbl ( `file_name`, `file_datetime`,`file_link`, `user_id` )
                    VALUES (:filename, '".date('Y-m-d H:i:s')."',:filelink,:userid)";

        $stmt = $con -> prepare( $query );
        $stmt -> execute( $arr );

    }

    exit(json_encode(array('r_code' => $response_code)));
    break;

Open the folder where you want to save your files and ask if exists a file with that name, if its true then dont save it — Hail Hydra, Sep 28 '16 at 02:17
Your script is quite insecure. I suggest you take a look at my answer to this question: http://stackoverflow.com/questions/38509334/full-secure-image-upload-script It generates unique file names for uploaded files, but more importantly, it teaches you how to write a secure upload script. — icecub, Sep 28 '16 at 02:26

score 1 · Accepted Answer · answered Sep 28 '16 at 03:07

1

<?php
$file='file-to-check.ext';
if (file_exists($file)) {
    echo "exists";
} else {
    echo "not exist";
}
?>

works for me - obviously the $file could also include a path - this script checks only the current folder

answered Sep 28 '16 at 03:07

kerry

671
1
5
9

but i agree with @icecub there is more work needed on your script – kerry Sep 28 '16 at 03:09
Thank you for the response. – E. Martinnez Sep 30 '16 at 08:57

score 0 · Answer 2 · answered Sep 28 '16 at 03:08

0

simple code could like this:

$file_name = 'path/to/file_name.ext';
if (file_exist($file_name)) {
    return true;
} else {
    move_uploaded_file($_FILES['upload-file']['tmp_name'], $file_name);
    insert into database;
    return true;
}

besides, you should not compare two files noly with file name.

answered Sep 28 '16 at 03:08

yiming.xie

23
1
1
7

Thank you for the response. – E. Martinnez Sep 30 '16 at 08:58

score 0 · Answer 3 · answered Sep 28 '16 at 03:11

<?php
case 'upload-file':

$arr = [ 
    ":userid" => $_SESSION['loggedIn_PH'][0]['user_id'],
    ":filename" => $_FILES['upload-file']['name'],
    ":filelink" => $_FILES['upload-file']['tmp_name']
    ];

    $allowed =  array('xls','xlsx');
    $filename = $_FILES['upload-file']['name'];
    $ext = pathinfo($filename, PATHINFO_EXTENSION);

    if(!in_array($ext,$allowed) ) {
        $response_code = -1;
    }else{
        $response_code = -1;
        $folder = time();
        mkdir("path/".$folder);
        $file = "path".DIRECTORY_SEPARATOR.$folder.DIRECTORY_SEPARATOR.$_FILES['upload-file']['name'];
if(!file_exists($file)){
    $response_code = 1;
                move_uploaded_file($_FILES['upload-file']['tmp_name'], $file);

    $query = "INSERT INTO file_rec_tbl ( `file_name`, `file_datetime`,`file_link`, `user_id` )
                VALUES (:filename, '".date('Y-m-d H:i:s')."',:filelink,:userid)";

    $stmt = $con -> prepare( $query );
    $stmt -> execute( $arr );
}

}

exit(json_encode(array('r_code' => $response_code)));

?>

Thank you for the response. – E. Martinnez Sep 30 '16 at 08:58 — E. Martinnez, Sep 30 '16 at 08:58

How to avoid duplicate file in upload using PHP?

3 Answers3