My fragment not showing on OnClickListener by button

Question

I have a problem with fragment, what i create:

Here is a custom List

    class CustomList extends ArrayAdapter<String> {

    private final Activity activity;
    private final String[] web;
    private final Integer[] imageID;

    CustomList(Activity activity, String[] web, Integer[] imageID){
        super(activity, R.layout.list_single, web);
        this.activity = activity;
        this.web = web;
        this.imageID = imageID;
    }

    @NonNull
    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        LayoutInflater inflater = activity.getLayoutInflater();
        View rowView = inflater.inflate(R.layout.list_single, null, true);
        TextView txtTitle = (TextView) rowView.findViewById(R.id.txt);
        ImageView img = (ImageView) rowView.findViewById(R.id.img);
        txtTitle.setText(web[position]);
        img.setImageResource(imageID[position]);
        return rowView;
    }
}

Here is a fragment:

    public class BackgroundSelectFragment extends Fragment {
        ListView list;
        String[] web = {
                "Clearing",
                "Scroll",
                "Desert",
                "World",
                "Old City",
                "Clip Board",
        } ;
        Integer[] imageId = {
                R.drawable.clearing,
                R.drawable.scroll,
                R.drawable.desert,
                R.drawable.world,
                R.drawable.city,
                R.drawable.clipboard,
        };

        @Nullable
        @Override
        public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
            View view = inflater.inflate(R.layout.listview_fragment, container, false);
            CustomList adapter = new
                    CustomList(getActivity(), web, imageId);
            list =  (ListView) container.findViewById(R.id.list);
            list.setAdapter(adapter);
            list.setOnItemClickListener(new AdapterView.OnItemClickListener() {
                @Override
                public void onItemClick(AdapterView<?> parent, View view,
                                        int position, long id) {
                    Toast.makeText(getActivity(), "You Clicked at " +web[+ position], Toast.LENGTH_SHORT).show();
                }
            });
            return view;
        }
}

and the last i try to open a fragment:

  backgroundBtn.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            FragmentManager fm = getFragmentManager();
            fm.beginTransaction()
                    .setCustomAnimations(android.R.animator.fade_in, android.R.animator.fade_out)
                    .show(backgroundSelectFragment)
                    .commit();
        }
    });

Im not got any error, when i click a button nothing appear, where is my fragment? Of course i initialize it in MainActivity OnCreate like:

backgroundSelectFragment = new BackgroundSelectFragment();

Please help. I dont know what i do wrong.

score 2 · Accepted Answer · edited May 23 '17 at 11:46

2

You have to either add or replace your fragment into your basic layout view

fm.beginTransaction()
                .setCustomAnimations(android.R.animator.fade_in,android.R.animator.fade_out)
                .replace(containerViewId, fragment, tag) //either use replace
                .add(containerViewId, fragment, tag) //or add
                .show(backgroundSelectFragment)
                .commit();

where containerViewId is the view where your fragment should be added You can find the differences between replace() and add here: Difference between add(), replace(), and addToBackStack()

edited May 23 '17 at 11:46

Community

1
1

answered Oct 05 '16 at 09:31

tsiro

2,323
3
24
46

Your answer work perfectly, But i have one question. What is best practice for fragment? Initialize them when activity is create like "add" and then on button just show and hide it? – Rodriquez Oct 05 '16 at 09:43
your are welcome...you could also accept my answer...it depends on what you would like to achieve...if you would like to show your fragment only when you click a button, you do not have to add your fragment on activity creation. You should add it only on button click.. – tsiro Oct 05 '16 at 09:47

score 0 · Answer 2 · answered Oct 05 '16 at 09:24

I think your code wrong in here please check this..

View view = inflater.inflate(R.layout.listview_fragment, container, false);
        CustomList adapter = new
                CustomList(getActivity(), web, imageId);
        list =  (ListView) **container**.findViewById(R.id.list);

to

View view = inflater.inflate(R.layout.listview_fragment, container, false);
        CustomList adapter = new
                CustomList(getActivity(), web, imageId);
        list =  (ListView) **view** .findViewById(R.id.list);

Thanks for answet, but this not help – Rodriquez Oct 05 '16 at 09:28 — Rodriquez, Oct 05 '16 at 09:28

score 0 · Answer 3 · answered Oct 05 '16 at 09:26

Try to use add or replace method for fragment transaction.

    FragmentManager fragmentManager = getFragmentManager(); 
    FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
    fragmentTransaction.setCustomAnimations(R.anim.slide_from_right, R.anim.slide_out_left, android.R.anim.slide_in_left, android.R.anim.slide_out_right);
    fragmentTransaction.add(container, fragment, fragment.getClass().getSimpleName());
    fragmentTransaction.commit();

Also change "container" to view in your fragment class for initializing view.

score 0 · Answer 4 · edited Oct 27 '16 at 03:47

Try below code inside button click event

   BackgroundSelectFragment bFragment = new BackgroundSelectFragment();
            getSupportFragmentManager().beginTransaction().setCustomAnimations(R.anim.slide_from_right, R.anim.slide_out_left, android.R.anim.slide_in_left, android.R.anim.slide_out_right).replace(R.id.fragmentContainer, bFragment).commit();

In here, R.id.fragmentContainer is the id of layout in which BackgroundSelectFragment is needed to be inflated.

My fragment not showing on OnClickListener by button

4 Answers4