Syntax Error: identifier 'Edge'?

Question

At the consturctor Node = new Node[numberOfNodes]; and Edge = new Edge[numberOfEdges]; gives identifier error? what's the wrong with it ?

typedef struct node
{
 int id;
 int x;
 int y;
} Node;

typedef struct edge
{
 int id;
 Node node1;
 Node node2;
} Edge;

class graph
{
private:
 int numberOfNodes;
 int numberOfEdges;
 int *Node;
 int *Edge;

public:
 graph(int nodes, int edges)
 {
  numberOfNodes = nodes;
  numberOfEdges = edges;
  Node = new Node[numberOfNodes];
  Edge = new Edge[numberOfEdges];
 }

Why the struct typedef? Just `struct _name_ { _members_ };` will do. — ergosys, Oct 22 '10 at 21:22

score 2 · Accepted Answer · edited May 23 '17 at 09:58

You have various variable name conflicts, including a conflict between your variable declaration int* Node, and the typedef Node. Also, you declare your array of nodes as type int* when it should be type Node*. You do the same with Edge. Try the following instead:

class graph
{
    private:
    int numberOfNodes;
    int numberOfEdges;
    Node* nodes_;
    Edge* edges_;

    public:

    graph(int num_nodes, int num_edges)
    {
        numberOfNodes = num_nodes;
        numberOfEdges = num_edges;
        nodes_ = new Node[numberOfNodes];
        edges_ = new Edge[numberOfEdges];
    }
};

Also, just for the future, the typedef struct { } idiom is really unnecessary in C++. It's main purpose was so that C programmers wouldn't need to constantly have to prefix their struct variables with the word struct. But in C++ this isn't necessary, so there's generally no real reason to say typedef struct node { ... } Node; when you can just say struct Node { ... };. See here for more information.

Victor Nicollet · Answer 2 · 2010-10-22T21:19:05.353

0

In your constructor, Node and Edge refer to the int* members of the class, not the type names in the global scope. You will have to indicate that you're referring to the global types:

Node = new ::Node[numberOfNodes];
Edge = new ::Edge[numberOfEdges];

Edit: of course, this would still confuse human readers. It's advised to keep type and variable names separate for the sake of your readers.

edited Oct 22 '10 at 21:19

answered Oct 22 '10 at 21:08

Victor Nicollet

24,361
4
58
89

3

This would work. But really, don't do it. – aschepler Oct 22 '10 at 21:09

score 0 · Answer 3 · answered Oct 22 '10 at 21:09

The compiler is confused by the fact that you used Node and Edge both as a type identifier (in typedef ... Node;) and as a class member (int *Node). I was confused for a while too. You can't really do that. In general, it's a good idea to choose different names for types, members, and variables that are supposed to be different.

score 0 · Answer 4 · answered Oct 22 '10 at 21:22

0

I'm sorry I've written nonsense things..it was like that. However I get still erors: Eerror C2440: '=' : cannot convert from 'Edge *' to 'int'

public:
    graph(int nodes, int edges)
    {
        numberOfNodes = nodes;
        numberOfEdges = edges;
        nodes = new Node[numberOfNodes];
        edges = new Edge[numberOfEdges];
    }

answered Oct 22 '10 at 21:22

anarhikos

1,415
3
15
19

I've seen my mistake. Thanks for all answers. – anarhikos Oct 22 '10 at 21:26

Syntax Error: identifier 'Edge'?

4 Answers4